about summary refs log tree commit diff
path: root/xlint
Commit message (Collapse)AuthorAgeFilesLines
* xlint: actually check ${version} in distfiles HEAD masterPiotr Wójcik2024-03-041-2/+1
| | | | | | | | \Q...\E already handles special characters partially reverts 2e0da76fef5f6659e0e98d7166e4497d23565831 Closes: #324 [via git-merge-pr]
* xlint: improve missing/multiply defined messages v0.66classabbyamp2024-01-251-2/+5
| | | | | | | | | | | these are the only messages that don't have a line number associated with them, adding complexity when parsing the output of xlint. - `'$var' missing!` only really makes sense with line number 1, as there is not really any other place to put it - `'$var' defined more than once` I decided to put on the *last* instance of the variable, and add a hint to where the previous definition(s) are
* xlint: fix short_desc max chars lint warning on 72 charstriallax2023-08-061-1/+1
| | | | | https://github.com/void-linux/void-packages/blob/master/Manual.md states that the description can have a maximum of 72 chars.
* Fix scan message substitution with bash as shPiotr Wójcik2023-07-091-3/+3
| | | | | | | | | | | before: srcpkgs/nawk/template:2: custom variables should use _ prefix: 2 srcpkgs/nawk/template:2: variable set to empty string: 2 after: srcpkgs/nawk/template:2: custom variables should use _ prefix: xxx= srcpkgs/nawk/template:2: variable set to empty string: xxx= Closes: #306 [via git-merge-pr]
* Clean up shell redirectstriallax2023-06-261-1/+1
| | | | | | | Some of these are outright wrong (e.g. `echo foo 2>&1`), others are just more verbose than they need to be. Closes: #304 [via git-merge-pr]
* xlint: lint crates.io distfile urlsclassabbyamp2023-04-271-0/+1
| | | | | | | | | | | | | | | this is painful: ``` distfiles="https://crates.io/api/v1/crates/pkgname/${version}/download>pkgname-${version}.tar.gz" ``` this is better, and xbps-src already supports extracting them: ``` distfiles="https://static.crates.io/crates/pkgname/pkgname-${version}.crate" ``` this replaces void-linux/void-packages#43417 as it adding new `_SITE` variables has been discouraged
* xlint: anchor revision must not be zero patternDuncan Overbruck2023-02-151-1/+1
|
* xlint: improve scanning of deprecated variablesclassabbyamp2022-11-241-3/+9
| | | | | previously, deprecated variables showed some spurious and confusing messages. now they should have a better message.
* xlint: detect trailing space in short_descBenjamín Albiñana2022-11-121-0/+1
|
* xlint: don't allow wrksrcclassabbyamp2022-11-081-4/+1
| | | | for void-linux/void-packages#40122
* xlint: check if vopt_if can be vopt_boolclassabbyamp2022-08-131-0/+1
| | | | | | fixes #257 Closes: #258 [via git-merge-pr]
* xlint: add disable_parallel_check to variable listclassabbyamp2022-06-301-0/+1
|
* Revert "xlint: lint multi-line value indentation"Leah Neukirchen2022-06-251-17/+0
| | | | | | | 18:59:51 <abby> leah2, can you revert the multiline lint for now, I'm working on a better way but it's too buggy to stay for now This reverts commit 16e6e3e9852c988b5bf0b416fabaeaa03588696f.
* xlint: lint multi-line value indentationclassabbyamp2022-06-251-0/+17
| | | | | | | | | | | - use awk because scan (grep) does not work over multiple lines - finds the opening and closing of a variable definition, then checks if it's on the first line and, if not, checks if the first characters are not <space><:graph:> - checks both single- and double-quoted strings, in a loop because shell makes that hard - detects lines in multi-line strings that end in a backslash - `| sort -u -k2` so it does not spam, similar to the other indent lint
* xlint: fix lints broken by extra sedclassabbyamp2022-06-251-3/+2
| | | | bug introduced in 8c0e21060fd0abdb16c10d62a56ead0a4da75062
* xlint: require specifying versions when using cargo updateJan Christian Grünhage2022-06-181-0/+2
| | | | Closes: #249 [via git-merge-pr]
* xlint: make output prefix consistentclassabbyamp2022-05-171-5/+6
| | | | | | | a few lints used the absolute path (`$template`) as prefix instead of `$argument` Closes: #246 [via git-merge-pr]
* xlint: remove print in explain_make_checkclassabbyamp2022-05-171-1/+1
| | | | | | | | | | | | | | | | | before (prints line before make_check): ``` $ xlint R shlib_provides="libR.so" /home/abi/void-packages/srcpkgs/R/template:28: explain why the tests fail ``` after: ``` $ xlint R /home/abi/void-packages/srcpkgs/R/template:28: explain why the tests fail ``` Closes: #245 [via git-merge-pr]
* xlint: escape slashes in scan() msg to prevent sed errorsclassabbyamp2022-05-171-1/+1
| | | | Closes: #244 [via git-merge-pr]
* xlint: check if manually defined wrksrc is defaultclassabbyamp2022-05-171-1/+8
| | | | | | | also add a regex_escape filter to reduce false-positives in a couple places Closes: #242 [via git-merge-pr]
* xlint: detect space before tabsLeah Neukirchen2022-05-161-0/+1
|
* xlint: deduplicate $pkgname and $versionclassabbyamp2022-05-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a slightly naïve solution that does not check if $pkgname matches the template's directory. That would not be very trivial to do to work with the git index functionality or subpackages, and I'm not quite sure how to handle that. Tested by putting two $pkgname and $version in a template. Before: ``` $ xlint chezmoi grep: the -P option only supports a single pattern chezmoi' chezmoi: 'pkgname' defined more than once chezmoi: 'version' defined more than once chezmoi: Place license= after pkgname= chezmoi: Place maintainer= after version= chezmoi:1: Header should be: # Template file for 'chezmoi chezmoi:4: revision does not appear immediately after version ``` After: ``` $ xlint chezmoi chezmoi: 'pkgname' defined more than once chezmoi: 'version' defined more than once chezmoi: Place license= after pkgname= chezmoi: Place maintainer= after version= chezmoi:4: revision does not appear immediately after version ```
* xlint: show line number of wrongly ordered linePiotr Wójcik2022-05-051-1/+5
|
* xlint: fix regexp for explain_make_checkLeah Neukirchen2022-03-281-1/+1
|
* xlint: check make_check comment v0.64Piotr Wójcik2022-03-261-0/+8
| | | | Closes: #220 [via git-merge-pr]
* xlint: reject underscore in versionPiotr Wójcik2022-03-261-1/+1
| | | | Closes: #110 [via git-merge-pr]
* xlint: fix bug in previous commitGonzalo Tornaría2022-02-211-3/+6
| | | | | | | | In scan() I was using $argument in the sed script, but oftentimes $arguments is a path including slashes which breaks havoc. Different way now, hopefully this is correct now. Note that $msg has to go through sed since some messages use `\2` to show the matching line.
* xlint: improvements to lint from git indexGonzalo Tornaría2022-02-201-7/+8
| | | | | | - do not leak $tmpfile in output from scan() - indent using tabs - add new options to README
* xlint: add option to lint from git indexGonzalo Tornaría2022-02-201-4/+17
| | | | | | | | | | | | | | This commit introduces two new uses of xlint: $ xlint :PKGNAME Lints the template corresponding to package PKGNAME as currently staged in the git index (i.e. the version that would be committed) $ xlint : Lints all templates that are changed in the git index. Useful to run from the pre-commit hook for the void-packages repo.
* xlint: check system_accounts underscore prefixPiotr Wójcik2021-10-041-0/+92
| | | | Existing accounts should keep their name.
* xlint: add nofixperms and nocheckperms variablesMichal Vasilek2021-08-261-0/+2
|
* xlint: clarify spaces were usedeater2021-07-121-1/+1
|
* xlint: add X11 to the list of vlicense-required licensesColin Booth2021-06-291-1/+1
| | | | | X11 is a derivative of the MIT license and contains the same license installation requirements.
* xlint: drop obsolete variable "only_for_archs"Leah Neukirchen2021-06-251-2/+0
|
* xlint: treat " WITH " as ", " in licenseĐoàn Trần Công Danh2021-05-291-1/+4
| | | | Closes: #211 [via git-merge-pr]
* xlint: ignore comments v0.63eater2021-02-151-0/+1
| | | | Closes: #177 [via git-merge-pr]
* xlint: allow make_check variable.Érico Rolim2021-02-121-0/+1
| | | | | | | See https://github.com/void-linux/void-packages/commit/2a748e7e6d9727a7e921d6b9a163e0eb17be98b9 Closes: #205 [via git-merge-pr]
* xlint: allow variable no_generic_pkgconfig_linkLeah Neukirchen2020-12-131-0/+1
|
* xlint: deprecate noarch.fosslinux2020-09-091-0/+1
|
* xlint: accept ignore_elf_dirs and ignore_elf_filesĐoàn Trần Công Danh2020-08-271-0/+2
| | | | | | | They're introduced by e0979275b4 (11-pkglint-elf-in-usrshare: allow explicit setting of exceptions, 2020-07-16) Closes: #195 [via git-merge-pr]
* xdbg,xi,xlint,xls,xq,xrs: redirect xdistdir stderr to /dev/null. v0.61Érico Rolim2020-07-261-1/+1
| | | | | | | These commands were outputting error messages from xdistdir when outside a void-packages folder, even though the command is supposed to fail silently. Closes: #190 [via git-merge-pr]
* xlint: accept pkgname as well as path to template. v0.60Érico Rolim2020-07-251-3/+12
| | | | Makes it possible to call xlint as: `xlint 0ad`.
* xlint: remove nonfree= checkStefano Ragni2020-07-251-1/+0
| | | | | | Fixes false positive on desc_option_nonfree= The deprecated nonfree=yes was removed from all templates so this check is not needed anymore
* xlint: preclude variables in homepagePiotr Wójcik2020-05-061-0/+1
|
* xlint: remove pycompile_version from list of acceptable variablesPiotr Wójcik2020-04-231-1/+0
| | | | Closes: #179 [via git-merge-pr]
* Revert "xlint: allow pycompile_module when pycompile_dirs is set"Piotr Wójcik2020-04-231-1/+0
| | | | This reverts commit 124b3b3ae9e42582abcd85ab30fb1a3c3f894632.
* xlint: add check for unverified python_versionAndrew J. Hesford2020-04-211-0/+1
| | | | Closes: #178 [via git-merge-pr]
* xlint: silence correct meson variables warningshtayerc2020-03-261-0/+3
| | | | Closes: #173 [via git-merge-pr]
* xlint: allow pycompile_module when pycompile_dirs is setĐoàn Trần Công Danh2020-01-301-0/+1
| | | | | | | | | Some packages likes Carla shippes python script in custom location, xbps-src hasn't been taught to detect it. Allow pycompile_module for those packages. Closes: #166 [via git-merge-pr]
* xlint: support autogenerated pycompile_module v0.57Piotr Wójcik2020-01-101-0/+1
|