about summary refs log tree commit diff
path: root/xlint
diff options
context:
space:
mode:
authorPiotr Wójcik <chocimier@tlen.pl>2018-10-26 18:54:45 +0200
committerLeah Neukirchen <leah@vuxu.org>2018-10-29 16:45:16 +0100
commite0a5ba96b84832610263d6a236077ab1cf74d653 (patch)
tree60f294bb12374475adf21ce5d411b75d08438c2e /xlint
parent966db3af8bea0676d60edc5bc594eb34c7eb9e71 (diff)
downloadxtools-e0a5ba96b84832610263d6a236077ab1cf74d653.tar.gz
xtools-e0a5ba96b84832610263d6a236077ab1cf74d653.tar.xz
xtools-e0a5ba96b84832610263d6a236077ab1cf74d653.zip
xlint: Refuse quoted pkgname and version
Except when they use variable substitution
Diffstat (limited to 'xlint')
-rwxr-xr-xxlint2
1 files changed, 2 insertions, 0 deletions
diff --git a/xlint b/xlint
index d86c81b..ff40424 100755
--- a/xlint
+++ b/xlint
@@ -156,9 +156,11 @@ for template; do
 	scan '^  ' "indent with tabs" | once
 	scan '[\t ]$' "trailing whitespace"
 	scan '[^\\]`' "use \$() instead of backticks"
+	scan '^pkgname="[^$]+"' "pkgname must not be quoted"
 	scan 'revision=0' "revision must not be zero"
 	scan '^version=.*[:-].*' "version must not contain the characters : or -"
 	scan '^version=.*\${.*[:!#%/^,@].*}.*' "version must not use shell variable substitution mechanism"
+	scan '^version="[^$]+"' "version must not be quoted"
 	scan '^reverts=.*-.*' "reverts must not contain package name"
 	scan '^reverts=(?!.*_.*).*' "reverts without revision"
 	scan 'replaces=(?=.*\w)[^<>]*$' "replaces needs depname with version"