Fix bug: ignores failure of libxml2 function - one cause of failure is running out of memory because of unusual input

git-svn-id: http://svn.code.sf.net/p/netpbm/code/trunk@2877 9d0c8265-081b-0410-96cb-a4ca84ce46f8

1 files changed, 17 insertions, 4 deletions

diff --git a/converter/other/svgtopam.c b/converter/other/svgtopam.c
index a10f51da..09e3a24e 100644
--- a/converter/other/svgtopam.c
+++ b/converter/other/svgtopam.c
@@ -103,16 +103,23 @@ parseCommandLine(int argc,
 /*============================================================================
    Wrappers for libxml2 routines.
 
-   The difference is that these use conventional C data types and have
-   shorter names.
+   The difference is that these use conventional C data types, have shorter
+   names, and abort the program instead of returning a special value when they
+   fail.
 =============================================================================*/
 
 static const char *
 getAttribute(xmlTextReaderPtr const xmlReaderP,
              const char *     const attributeName) {
 
-    return (const char *)
+    const char * const rc = (const char *)
         xmlTextReaderGetAttribute(xmlReaderP, (const xmlChar *)attributeName);
+
+    if (rc == NULL)
+        pm_error("xmlTextReaderGetAttribute(\"%.256s\") failed.  ",
+                 attributeName);
+
+    return rc;
 }
 
 
@@ -120,7 +127,13 @@ getAttribute(xmlTextReaderPtr const xmlReaderP,
 static const char *
 currentNodeName(xmlTextReaderPtr const xmlReaderP) {
 
-    return (const char *)xmlTextReaderConstName(xmlReaderP);
+    const char * const rc = (const char *)
+        xmlTextReaderConstName(xmlReaderP);
+
+    if (rc == NULL)
+        pm_error("xmlTextReaderConstName() failed.  ");
+
+    return rc;
 }