about summary refs log tree commit diff
diff options
context:
space:
mode:
authorgiraffedata <giraffedata@9d0c8265-081b-0410-96cb-a4ca84ce46f8>2017-04-20 22:46:50 +0000
committergiraffedata <giraffedata@9d0c8265-081b-0410-96cb-a4ca84ce46f8>2017-04-20 22:46:50 +0000
commitba0b4e1aa239457bcf5d99aa694fb803d3cc80a3 (patch)
tree7a54d34a99febb6ff52485f22e3ded8f61c73748
parenta35cb3047edcfb17d6b45275a38a51cb38c81158 (diff)
downloadnetpbm-mirror-ba0b4e1aa239457bcf5d99aa694fb803d3cc80a3.tar.gz
netpbm-mirror-ba0b4e1aa239457bcf5d99aa694fb803d3cc80a3.tar.xz
netpbm-mirror-ba0b4e1aa239457bcf5d99aa694fb803d3cc80a3.zip
Fix silent failure of pm_system_lp, pm_system_vp on Windows
git-svn-id: http://svn.code.sf.net/p/netpbm/code/trunk@2959 9d0c8265-081b-0410-96cb-a4ca84ce46f8
-rw-r--r--doc/HISTORY7
-rw-r--r--lib/libsystem_dummy.c16
2 files changed, 21 insertions, 2 deletions
diff --git a/doc/HISTORY b/doc/HISTORY
index 4b06c188..b37be8cd 100644
--- a/doc/HISTORY
+++ b/doc/HISTORY
@@ -25,6 +25,13 @@ not yet  BJH  Release 10.79.00
               pnmtojpeg: fix array bounds violation in argument list.  Always
               broken (pnmtojpeg was new to Netpbm in Netpbm 8.2 (March 2000).
 
+              Windows: fix bug: pm_system_lp() and pm_system_vp() fail
+              silently instead of with a clear error message in an environment
+              that does not provide Unix process management.  Always broken.
+              (pm_system_lp and pm_system_vp were new in Netpbm 10.40
+              (September 2007), but wouldn't even compile until Netpbm 10.42
+              (March 2008)).
+
               Debian packaging: fix bug: don't try to include Manweb files, as
               it is no longer packaged by 'make package'.
 
diff --git a/lib/libsystem_dummy.c b/lib/libsystem_dummy.c
index c89b4d5d..97dd8984 100644
--- a/lib/libsystem_dummy.c
+++ b/lib/libsystem_dummy.c
@@ -21,6 +21,12 @@ pm_system_vp(const char *    const progName,
              void *          const feederParm,
              void stdoutAccepter(int, void *),
              void *          const accepterParm) {
+
+    pm_error("This program wants to run another program using pm_system_vp() "
+             "in the libnetpbm library, but libnetpbm was built without "
+             "the pm_system_vp() facility -- probably because this system "
+             "doesn't have the process management facilities pm_system() "
+             "requires.");
 }
 
 void
@@ -30,6 +36,12 @@ pm_system_lp(const char *    const progName,
              void stdoutAccepter(int, void *),
              void *          const accepterParm,
              ...) {
+
+    pm_error("This program wants to run another program using pm_system_lp() "
+             "in the libnetpbm library, but libnetpbm was built without "
+             "the pm_system_lp() facility -- probably because this system "
+             "doesn't have the process management facilities pm_system() "
+             "requires.");
 }
 
 void
@@ -39,8 +51,8 @@ pm_system(void                  stdinFeeder(int, void *),
           void *          const accepterParm,
           const char *    const shellCommand) {
 
-    pm_error("This program wants to run another program using pm_system() in "
-             "the libnetpbm library, but libnetpbm was built without "
+    pm_error("This program wants to run another program using pm_system() "
+             "in the libnetpbm library, but libnetpbm was built without "
              "the pm_system() facility -- probably because this system "
              "doesn't have the process management facilities pm_system() "
              "requires.");