about summary refs log tree commit diff
diff options
context:
space:
mode:
authorgiraffedata <giraffedata@9d0c8265-081b-0410-96cb-a4ca84ce46f8>2022-01-31 00:54:02 +0000
committergiraffedata <giraffedata@9d0c8265-081b-0410-96cb-a4ca84ce46f8>2022-01-31 00:54:02 +0000
commita58038cc201dae56aac1b55c2f8ec70724d760d1 (patch)
treed720c42af64135c3b355c3293148c85341c631d4
parent5e9e01d59519944fb87a657b93fbf0ac3c2f07de (diff)
downloadnetpbm-mirror-a58038cc201dae56aac1b55c2f8ec70724d760d1.tar.gz
netpbm-mirror-a58038cc201dae56aac1b55c2f8ec70724d760d1.tar.xz
netpbm-mirror-a58038cc201dae56aac1b55c2f8ec70724d760d1.zip
Fix bogus warning about color not being exactly representable
git-svn-id: http://svn.code.sf.net/p/netpbm/code/trunk@4268 9d0c8265-081b-0410-96cb-a4ca84ce46f8
-rw-r--r--doc/HISTORY4
-rw-r--r--lib/libpamcolor.c2
2 files changed, 5 insertions, 1 deletions
diff --git a/doc/HISTORY b/doc/HISTORY
index e1d1c74f..8a868939 100644
--- a/doc/HISTORY
+++ b/doc/HISTORY
@@ -6,6 +6,10 @@ CHANGE HISTORY
 
 not yet  BJH  Release 10.98.00
 
+              libnetpbm, various programs: fix bug: bogus warning that a color
+              specified on command line cannot be represented exactly with the
+              maxval being used.  Introduced in Netpbm 10.83 (June 2018).
+
               pnmtopsnr: Fix typo in error message.  Always broken (pnmpsnr
               was new in Netpbm 9.6 (July 2000).
 
diff --git a/lib/libpamcolor.c b/lib/libpamcolor.c
index 718df89f..cc68fe1a 100644
--- a/lib/libpamcolor.c
+++ b/lib/libpamcolor.c
@@ -338,7 +338,7 @@ warnIfNotExact(const char * const colorname,
 
     float const epsilon = 1.0/65536.0;
 
-    if (fabs((float)(rounded[plane] / maxval) - exact[plane]) > epsilon) {
+    if (fabs(((float)rounded[plane] / maxval) - exact[plane]) > epsilon) {
         pm_message("WARNING: Component %u of color '%s' is %f, "
                    "which cannot be represented precisely with maxval %lu.  "
                    "Approximating as %lu.",