about summary refs log tree commit diff
path: root/libio
diff options
context:
space:
mode:
authorJoe Simmons-Talbott <josimmon@redhat.com>2023-03-22 14:04:30 -0400
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2023-03-28 10:12:30 -0300
commit868506eb427c9dcc6d869cd4885679be04e1b7dd (patch)
tree11233f242405423c14ff09fe781131696d4c73b0 /libio
parent31bfe3ef4ea898df606cb6cc59ac72de27002b01 (diff)
downloadglibc-868506eb427c9dcc6d869cd4885679be04e1b7dd.tar.gz
glibc-868506eb427c9dcc6d869cd4885679be04e1b7dd.tar.xz
glibc-868506eb427c9dcc6d869cd4885679be04e1b7dd.zip
system: Add "--" after "-c" for sh (BZ #28519)
Prevent sh from interpreting a user string as shell options if it
starts with '-' or '+'.  Since the version of /bin/sh used for testing
system() is different from the full-fledged system /bin/sh add support
to it for handling "--" after "-c".  Add a testcase to ensure the
expected behavior.

Signed-off-by: Joe Simmons-Talbott <josimmon@redhat.com>
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
Diffstat (limited to 'libio')
-rw-r--r--libio/iopopen.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libio/iopopen.c b/libio/iopopen.c
index a64033e60f..4cc405f2de 100644
--- a/libio/iopopen.c
+++ b/libio/iopopen.c
@@ -87,7 +87,7 @@ spawn_process (posix_spawn_file_actions_t *fa, FILE *fp, const char *command,
     }
 
   err = __posix_spawn (&((_IO_proc_file *) fp)->pid, _PATH_BSHELL, fa, 0,
-		       (char *const[]){ (char*) "sh", (char*) "-c",
+		       (char *const[]){ (char*) "sh", (char*) "-c", (char*) "--",
 		       (char *) command, NULL }, __environ);
   if (err != 0)
     return err;