From 868506eb427c9dcc6d869cd4885679be04e1b7dd Mon Sep 17 00:00:00 2001 From: Joe Simmons-Talbott Date: Wed, 22 Mar 2023 14:04:30 -0400 Subject: system: Add "--" after "-c" for sh (BZ #28519) Prevent sh from interpreting a user string as shell options if it starts with '-' or '+'. Since the version of /bin/sh used for testing system() is different from the full-fledged system /bin/sh add support to it for handling "--" after "-c". Add a testcase to ensure the expected behavior. Signed-off-by: Joe Simmons-Talbott Reviewed-by: Adhemerval Zanella --- libio/iopopen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libio') diff --git a/libio/iopopen.c b/libio/iopopen.c index a64033e60f..4cc405f2de 100644 --- a/libio/iopopen.c +++ b/libio/iopopen.c @@ -87,7 +87,7 @@ spawn_process (posix_spawn_file_actions_t *fa, FILE *fp, const char *command, } err = __posix_spawn (&((_IO_proc_file *) fp)->pid, _PATH_BSHELL, fa, 0, - (char *const[]){ (char*) "sh", (char*) "-c", + (char *const[]){ (char*) "sh", (char*) "-c", (char*) "--", (char *) command, NULL }, __environ); if (err != 0) return err; -- cgit 1.4.1