about summary refs log tree commit diff
path: root/ChangeLog
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.com>2015-04-23 09:17:42 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2015-06-09 18:10:19 -0300
commit7cbeabac0fb28e24c99aaa5085e613ea543a2346 (patch)
treed51c207e3179fc7c1f03f53c3361224585429e8c /ChangeLog
parent2f44ee08dbf51d39ef5692699cc35f93faf64db1 (diff)
downloadglibc-7cbeabac0fb28e24c99aaa5085e613ea543a2346.tar.gz
glibc-7cbeabac0fb28e24c99aaa5085e613ea543a2346.tar.xz
glibc-7cbeabac0fb28e24c99aaa5085e613ea543a2346.zip
x86: Remove vsyscall usage
This patch removes the vsyscall usage for x86_64 port.  As indicated
by kernel code comments [1], vsyscalls are a legacy ABI and its concept
is problematic:

- It interferes with ASLR.
- It's awkward to write code that lives in kernel addresses but is
  callable by userspace at fixed addresses.
- The whole concept is impossible for 32-bit compat userspace.
- UML cannot easily virtualize a vsyscall.

The VDSO is a better approach for such functionality.  Tested on i686,
x86_64, and x32.

	* sysdeps/unix/sysv/linux/i386/gettimeofday.c
	(__gettimeofday_syscall): Remove vsyscall fallback.
	* sysdeps/unix/sysv/linux/i386/time.c (__time_syscall): Likewise.
	* sysdeps/unix/sysv/linux/x86/gettimeofday.c (__gettimeofday_syscall):
	Add syscall fallback function.
	(gettimeofday_ifunc): Use __gettimeofday_syscall as fallback mechanism
	if vDSO is not present.
	* sysdeps/unix/sysv/linux/x86/time.c (__time_syscall): Add syscall
	fallback function.
	(time_ifunc): Use __time_syscall as fallback mechanism if vDSO is not
	present.
	* sysdeps/unix/sysv/linux/x86_64/gettimeofday.c: Remove file.
	* sysdeps/unix/sysv/linux/x86_64/time.c: Likewise.

[1] arch/x86/kernel/vsyscall_64.c
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog16
1 files changed, 16 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 2501f45873..5f745e72b4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,19 @@
+2015-06-09  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
+
+	* sysdeps/unix/sysv/linux/i386/gettimeofday.c
+	(__gettimeofday_syscall): Remove vsyscall fallback.
+	* sysdeps/unix/sysv/linux/i386/time.c (__time_syscall): Likewise.
+	* sysdeps/unix/sysv/linux/x86/gettimeofday.c (__gettimeofday_syscall):
+	Add syscall fallback function.
+	(gettimeofday_ifunc): Use __gettimeofday_syscall as fallback mechanism
+	if vDSO is not present.
+	* sysdeps/unix/sysv/linux/x86/time.c (__time_syscall): Add syscall
+	fallback function.
+	(time_ifunc): Use __time_syscall as fallback mechanism if vDSO is not
+	present.
+	* sysdeps/unix/sysv/linux/x86_64/gettimeofday.c: Remove file.
+	* sysdeps/unix/sysv/linux/x86_64/time.c: Likewise.
+
 2015-06-09  Joseph Myers  <joseph@codesourcery.com>
 
 	[BZ #18497]