From 7cbeabac0fb28e24c99aaa5085e613ea543a2346 Mon Sep 17 00:00:00 2001 From: Adhemerval Zanella Date: Thu, 23 Apr 2015 09:17:42 -0300 Subject: x86: Remove vsyscall usage This patch removes the vsyscall usage for x86_64 port. As indicated by kernel code comments [1], vsyscalls are a legacy ABI and its concept is problematic: - It interferes with ASLR. - It's awkward to write code that lives in kernel addresses but is callable by userspace at fixed addresses. - The whole concept is impossible for 32-bit compat userspace. - UML cannot easily virtualize a vsyscall. The VDSO is a better approach for such functionality. Tested on i686, x86_64, and x32. * sysdeps/unix/sysv/linux/i386/gettimeofday.c (__gettimeofday_syscall): Remove vsyscall fallback. * sysdeps/unix/sysv/linux/i386/time.c (__time_syscall): Likewise. * sysdeps/unix/sysv/linux/x86/gettimeofday.c (__gettimeofday_syscall): Add syscall fallback function. (gettimeofday_ifunc): Use __gettimeofday_syscall as fallback mechanism if vDSO is not present. * sysdeps/unix/sysv/linux/x86/time.c (__time_syscall): Add syscall fallback function. (time_ifunc): Use __time_syscall as fallback mechanism if vDSO is not present. * sysdeps/unix/sysv/linux/x86_64/gettimeofday.c: Remove file. * sysdeps/unix/sysv/linux/x86_64/time.c: Likewise. [1] arch/x86/kernel/vsyscall_64.c --- ChangeLog | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index 2501f45873..5f745e72b4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,19 @@ +2015-06-09 Adhemerval Zanella + + * sysdeps/unix/sysv/linux/i386/gettimeofday.c + (__gettimeofday_syscall): Remove vsyscall fallback. + * sysdeps/unix/sysv/linux/i386/time.c (__time_syscall): Likewise. + * sysdeps/unix/sysv/linux/x86/gettimeofday.c (__gettimeofday_syscall): + Add syscall fallback function. + (gettimeofday_ifunc): Use __gettimeofday_syscall as fallback mechanism + if vDSO is not present. + * sysdeps/unix/sysv/linux/x86/time.c (__time_syscall): Add syscall + fallback function. + (time_ifunc): Use __time_syscall as fallback mechanism if vDSO is not + present. + * sysdeps/unix/sysv/linux/x86_64/gettimeofday.c: Remove file. + * sysdeps/unix/sysv/linux/x86_64/time.c: Likewise. + 2015-06-09 Joseph Myers [BZ #18497] -- cgit 1.4.1