about summary refs log tree commit diff
path: root/lib/libppm1.c
diff options
context:
space:
mode:
Diffstat (limited to 'lib/libppm1.c')
-rw-r--r--lib/libppm1.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/libppm1.c b/lib/libppm1.c
index 0658529a..ff940540 100644
--- a/lib/libppm1.c
+++ b/lib/libppm1.c
@@ -246,7 +246,7 @@ validateRppmRow(pixel *       const pixelrow,
     } else {
         unsigned int col;
 
-        for (col = 0; col < cols; ++col) {
+        for (col = 0, *errorP = NULL; col < cols && !*errorP; ++col) {
             pixval const r = PPM_GETR(pixelrow[col]);
             pixval const g = PPM_GETG(pixelrow[col]);
             pixval const b = PPM_GETB(pixelrow[col]);
@@ -256,12 +256,12 @@ validateRppmRow(pixel *       const pixelrow,
                     errorP,
                     "Red sample value %u is greater than maxval (%u)",
                     r, maxval);
-            if (g > maxval)
+            else if (g > maxval)
                 pm_asprintf(
                     errorP,
                     "Green sample value %u is greater than maxval (%u)",
                     g, maxval);
-            if (b > maxval)
+            else if (b > maxval)
                 pm_asprintf(
                     errorP,
                     "Blue sample value %u is greater than maxval (%u)",