about summary refs log tree commit diff
path: root/Src/builtin.c
diff options
context:
space:
mode:
authorBart Schaefer <schaefer@zsh.org>2023-10-26 08:27:18 -0700
committerBart Schaefer <schaefer@zsh.org>2023-10-26 08:27:18 -0700
commit98a6892cb138a53dc4a265e29e60dbbd813f3d73 (patch)
treec199aa5da26d9d02912abe1c71df5b6b70e24bb3 /Src/builtin.c
parent0c15cc8712b5b3c83d52b1c27f416db80d3426aa (diff)
downloadzsh-98a6892cb138a53dc4a265e29e60dbbd813f3d73.tar.gz
zsh-98a6892cb138a53dc4a265e29e60dbbd813f3d73.tar.xz
zsh-98a6892cb138a53dc4a265e29e60dbbd813f3d73.zip
52244: Fix a batch of minor defects reported by Coverity.
Coverity defects 1547831, 1547826 (remove unused function), 1521551,
1500752, 1500747, 1401549, 1372423, 1270645, 1255799, 1255792, 1255789,
1255787, 1255782, 1255750
Diffstat (limited to 'Src/builtin.c')
-rw-r--r--Src/builtin.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/Src/builtin.c b/Src/builtin.c
index 31af66c7c..9e08a1dbc 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -6508,6 +6508,7 @@ bin_read(char *name, char **args, Options ops, UNUSED(int func))
 
     if (OPT_ISSET(ops,'s') && SHTTY == readfd) {
 	struct ttyinfo ti;
+	memset(&ti, 0, sizeof(struct ttyinfo));
 	gettyinfo(&ti);
 	saveti = ti;
 	resettty = 1;
@@ -6606,7 +6607,8 @@ bin_read(char *name, char **args, Options ops, UNUSED(int func))
 		else if (resettty && SHTTY != -1)
 		    settyinfo(&saveti);
 		if (haso) {
-		    fclose(shout);
+		    if (shout)
+			fclose(shout);
 		    shout = oshout;
 		    SHTTY = -1;
 		}