about summary refs log tree commit diff
path: root/ChangeLog
diff options
context:
space:
mode:
authorDaniel Shahaf <d.s@daniel.shahaf.name>2022-01-26 14:18:45 +0000
committerDaniel Shahaf <d.s@daniel.shahaf.name>2022-01-29 10:08:42 +0000
commita803a5f4c46629c18c05a9ee09d5ae34407e35c4 (patch)
tree12bd900db2a611a5118744c96d67767b6317af14 /ChangeLog
parentcb2b0e7c6cdd851f79b6856335e8ab7a3d3d1935 (diff)
downloadzsh-a803a5f4c46629c18c05a9ee09d5ae34407e35c4.tar.gz
zsh-a803a5f4c46629c18c05a9ee09d5ae34407e35c4.tar.xz
zsh-a803a5f4c46629c18c05a9ee09d5ae34407e35c4.zip
49713: _subversion: commit, diff, revert: Update completions for svn 1.7 and newer
* _svn_deletedfiles: Remove.
    The last version of svn(1) under which that function could possibly
    complete anything, svn 1.6.x, was EOLed in 2013.  Newer versions
    don't have a "text-base" directory, so $controlled is set to an
    empty array, so this function returned false for all files, so
    in 'svn rm' (up to the previous commit) all files were completed
    (because that's what '_files -g "*(e:false:)"' does).

* _svn_status: Remove.
    Versions of svn newer than the aforementioned 1.6.x have an
    entries file but never modify it, so the "mtime has changed" check
    would false negative.  Therefore, sequences such as:
    .
        svn <TAB>
        echo >> some/versioned/file
        svn ci <TAB>
    .
    wouldn't offer some/versioned/file.
    .
    Furthermore, completion would offer directories with no changed
    files in them, and even unversioned directories.  Now only changed
    files/directories are offered.

* _cache_svn_status, _cache_svn_mtime: Remove.
    If these hadn't been removed, I would have moved their declarations
    to file scope so _svn_status could be used from outside this file,
    too.

The replacement function, _svn_modified, doesn't have cache support, but
does honour the 'verbose' style to inhibit recursion to subdirectories.
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog3
1 files changed, 3 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog
index 9d308258a..15e3a9999 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2022-01-29  Daniel Shahaf  <d.s@daniel.shahaf.name>
 
+	* 49713: Completion/Unix/Command/_subversion: commit, diff,
+	revert: Update completions for svn 1.7 and newer
+
 	* 49712: Completion/Unix/Command/_subversion: svn rm: Complete
 	all svn-controlled files, not only missing/deleted files