about summary refs log tree commit diff
diff options
context:
space:
mode:
authorBart Schaefer <schaefer@zsh.org>2023-02-12 09:52:39 -0800
committerBart Schaefer <schaefer@zsh.org>2023-02-12 09:52:39 -0800
commitd3edf318306e37d2d96c4e4ea442d10207722e94 (patch)
tree105fefefbd0de54f0dbd07c7672553120842ec79
parent6502d05897a7d9441fcabfd24f203cffe4da59aa (diff)
downloadzsh-d3edf318306e37d2d96c4e4ea442d10207722e94.tar.gz
zsh-d3edf318306e37d2d96c4e4ea442d10207722e94.tar.xz
zsh-d3edf318306e37d2d96c4e4ea442d10207722e94.zip
51404: Nullify filelist after deleting (fix segfault)
-rw-r--r--ChangeLog4
-rw-r--r--Src/jobs.c8
2 files changed, 10 insertions, 2 deletions
diff --git a/ChangeLog b/ChangeLog
index bbe45a3f4..7f467a8ac 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2023-02-12  Bart Schaefer  <schaefer@zsh.org>
+
+	* 51404: Src/jobs.c: Nullify filelist after deleting (fix segfault)
+
 2023-02-09  Oliver Kiddle  <opk@zsh.org>
 
 	* 51320, 51383: Src/Zle/zle_main.c, Src/Zle/complist.c,
diff --git a/Src/jobs.c b/Src/jobs.c
index 4863962b9..59ddd952e 100644
--- a/Src/jobs.c
+++ b/Src/jobs.c
@@ -1372,8 +1372,10 @@ cleanfilelists(void)
 
     DPUTS(shell_exiting >= 0, "BUG: cleanfilelists() before exit");
  
-    for (i = 1; i <= maxjob; i++)
+    for (i = 1; i <= maxjob; i++) {
 	deletefilelist(jobtab[i].filelist, 0);
+	jobtab[i].filelist = 0;
+    }
 }
 
 /**/
@@ -1531,8 +1533,10 @@ havefiles(void)
     int i;
 
     for (i = 1; i <= maxjob; i++)
-	if (jobtab[i].stat && jobtab[i].filelist)
+	if (jobtab[i].stat && jobtab[i].filelist &&
+	    peekfirst(jobtab[i].filelist)) {
 	    return 1;
+	}
     return 0;
 
 }