about summary refs log tree commit diff
diff options
context:
space:
mode:
authorHong Xu <hong@topbug.net>2014-02-23 20:25:04 -0800
committerPeter Stephenson <pws@zsh.org>2014-02-24 09:32:01 +0000
commite5b55ebf4546b82a1cc5c2b03d404da046a28df2 (patch)
treee5ee50da220838f9049532c9c7087a792065d135
parentafe7ff6b5dc6e979aae1695635349a33468f7d12 (diff)
downloadzsh-e5b55ebf4546b82a1cc5c2b03d404da046a28df2.tar.gz
zsh-e5b55ebf4546b82a1cc5c2b03d404da046a28df2.tar.xz
zsh-e5b55ebf4546b82a1cc5c2b03d404da046a28df2.zip
Fix outdated npm completion
-rw-r--r--ChangeLog3
-rw-r--r--Completion/Unix/Command/_npm20
2 files changed, 8 insertions, 15 deletions
diff --git a/ChangeLog b/ChangeLog
index 6827f5ec0..49dcf6b62 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2014-02-24  Peter Stephenson  <p.stephenson@samsung.com>
 
+	* Hong Xu: 32492: Completion/Unix/Command/_npm: fix outdated
+	completion.
+
 	* Sebastien Alaiwan: 32462: Completion/Unix/Command/_bzr:
 	improve completion with directory path.
 
diff --git a/Completion/Unix/Command/_npm b/Completion/Unix/Command/_npm
index 24b536188..f5493a321 100644
--- a/Completion/Unix/Command/_npm
+++ b/Completion/Unix/Command/_npm
@@ -1,19 +1,9 @@
 #compdef npm
 
-# Node Package Manager 0.3.15 completion, letting npm do all the completion work
+# Node Package Manager completion, letting npm do all the completion work
 
-_npm() {
-  compadd -- $(_npm_complete $words)
-}
+if type npm > /dev/null; then
+  eval "$(npm completion)"
 
-# We want to show all errors of any substance, but never the "npm (not )ok" one.
-# (Also doesn't consider "ERR! no match found" worth breaking the terminal for.)
-_npm_complete() {
-  local ask_npm
-  ask_npm=(npm completion --color false --loglevel error -- $@)
-  { _call_program npm $ask_npm 2>&1 >&3 \
-  | egrep -v '^(npm (not |)ok|ERR! no match found)$' >&2; \
-  } 3>&1
-}
-
-_npm "$@"
+  _npm_completion "$@"
+fi