about summary refs log tree commit diff
diff options
context:
space:
mode:
authorPeter Stephenson <pws@users.sourceforge.net>2002-09-03 19:33:00 +0000
committerPeter Stephenson <pws@users.sourceforge.net>2002-09-03 19:33:00 +0000
commit56565320c18ec4ba9e7ca4ad7207b62eccc50f7b (patch)
tree6a5051920655adb82cd5991f5f07cb3b5e88f8b4
parent30aa9063e8163ac77e61caa32169e5c1f8d2e16b (diff)
downloadzsh-56565320c18ec4ba9e7ca4ad7207b62eccc50f7b.tar.gz
zsh-56565320c18ec4ba9e7ca4ad7207b62eccc50f7b.tar.xz
zsh-56565320c18ec4ba9e7ca4ad7207b62eccc50f7b.zip
17608: comment on use and abuse of BINF_SKIPINVALID
-rw-r--r--ChangeLog5
-rw-r--r--Src/builtin.c10
2 files changed, 14 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index 5fc46a72c..58d30e095 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2002-09-03  Peter Stephenson  <pws@csr.com>
+
+	* 17608: Src/builtins.c: comment on use and abuse of
+	BINF_SKIPINVALID.
+
 2002-09-03  Oliver Kiddle  <opk@zsh.org>
 
 	* Thomas Köhler: 176xx: Completion/Unix/Command/_ssh: also pass
diff --git a/Src/builtin.c b/Src/builtin.c
index 628f23f83..c3951c77f 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -303,7 +303,15 @@ execbuiltin(LinkList args, Builtin bn)
 		    argv++;
 		    break;
 		}
-		/* unrecognised options to echo etc. are not really options */
+		/*
+		 * Unrecognised options to echo etc. are not really
+		 * options.
+		 *
+		 * Note this flag is not smart enough to handle option
+		 * arguments.  In fact, ideally it shouldn't be added
+		 * to any new builtins, to preserve standard option
+		 * handling as much as possible.
+		*/
 		if (flags & BINF_SKIPINVALID) {
 		    char *p = arg;
 		    if (optstr)