From 56565320c18ec4ba9e7ca4ad7207b62eccc50f7b Mon Sep 17 00:00:00 2001 From: Peter Stephenson Date: Tue, 3 Sep 2002 19:33:00 +0000 Subject: 17608: comment on use and abuse of BINF_SKIPINVALID --- ChangeLog | 5 +++++ Src/builtin.c | 10 +++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 5fc46a72c..58d30e095 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2002-09-03 Peter Stephenson + + * 17608: Src/builtins.c: comment on use and abuse of + BINF_SKIPINVALID. + 2002-09-03 Oliver Kiddle * Thomas Köhler: 176xx: Completion/Unix/Command/_ssh: also pass diff --git a/Src/builtin.c b/Src/builtin.c index 628f23f83..c3951c77f 100644 --- a/Src/builtin.c +++ b/Src/builtin.c @@ -303,7 +303,15 @@ execbuiltin(LinkList args, Builtin bn) argv++; break; } - /* unrecognised options to echo etc. are not really options */ + /* + * Unrecognised options to echo etc. are not really + * options. + * + * Note this flag is not smart enough to handle option + * arguments. In fact, ideally it shouldn't be added + * to any new builtins, to preserve standard option + * handling as much as possible. + */ if (flags & BINF_SKIPINVALID) { char *p = arg; if (optstr) -- cgit 1.4.1