diff options
| author | Philipp Hagemeister <phihag@phihag.de> | 2015-10-09 09:09:22 +0200 |
|---|---|---|
| committer | Philipp Hagemeister <phihag@phihag.de> | 2015-10-09 09:09:22 +0200 |
| commit | ef47b2c15f3fa9d9d491090f2ea46d2bd9967d21 (patch) | |
| tree | 00ef0fe1a29ed9e8425a4ca143ab78064863c8cd /CONTRIBUTING.md | |
| parent | 57935b2564c082b90a60468d4c844b219118886a (diff) | |
| download | youtube-dl-ef47b2c15f3fa9d9d491090f2ea46d2bd9967d21.tar.gz youtube-dl-ef47b2c15f3fa9d9d491090f2ea46d2bd9967d21.tar.xz youtube-dl-ef47b2c15f3fa9d9d491090f2ea46d2bd9967d21.zip | |
release 2015.10.09 2015.10.09
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 57a94231d..32c2fd84c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -124,7 +124,7 @@ If you want to add support for a new site, you can follow this quick list (assum } ``` 5. Add an import in [`youtube_dl/extractor/__init__.py`](https://github.com/rg3/youtube-dl/blob/master/youtube_dl/extractor/__init__.py). -6. Run `python test/test_download.py TestDownload.test_YourExtractor`. This *should fail* at first, but you can continually re-run it until you're done. If you decide to add more than one test, then rename ``_TEST`` to ``_TESTS`` and make it into a list of dictionaries. The tests will be then be named `TestDownload.test_YourExtractor`, `TestDownload.test_YourExtractor_1`, `TestDownload.test_YourExtractor_2`, etc. +6. Run `python test/test_download.py TestDownload.test_YourExtractor`. This *should fail* at first, but you can continually re-run it until you're done. If you decide to add more than one test, then rename ``_TEST`` to ``_TESTS`` and make it into a list of dictionaries. The tests will then be named `TestDownload.test_YourExtractor`, `TestDownload.test_YourExtractor_1`, `TestDownload.test_YourExtractor_2`, etc. 7. Have a look at [`youtube_dl/extractor/common.py`](https://github.com/rg3/youtube-dl/blob/master/youtube_dl/extractor/common.py) for possible helper methods and a [detailed description of what your extractor should and may return](https://github.com/rg3/youtube-dl/blob/master/youtube_dl/extractor/common.py#L62-L200). Add tests and code for as many as you want. 8. If you can, check the code with [flake8](https://pypi.python.org/pypi/flake8). 9. When the tests pass, [add](http://git-scm.com/docs/git-add) the new files and [commit](http://git-scm.com/docs/git-commit) them and [push](http://git-scm.com/docs/git-push) the result, like this: |