diff options
| author | Sergey M․ <dstftw@gmail.com> | 2020-12-13 22:46:17 +0700 |
|---|---|---|
| committer | Sergey M․ <dstftw@gmail.com> | 2020-12-13 22:46:17 +0700 |
| commit | ace52668f0c9d23bc8d2e2a51d50d03b1b96c90e (patch) | |
| tree | f6b9e6c66787b6aad0aed112e82ef480e64acef9 /.github | |
| parent | 9c33eb027e4a798045706f669679a4f9305e1fdf (diff) | |
| download | youtube-dl-ace52668f0c9d23bc8d2e2a51d50d03b1b96c90e.tar.gz youtube-dl-ace52668f0c9d23bc8d2e2a51d50d03b1b96c90e.tar.xz youtube-dl-ace52668f0c9d23bc8d2e2a51d50d03b1b96c90e.zip | |
[PULL_REQUEST_TEMPLATE.md] Add tests requirement and make coding conventions requirement more explicit
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e69b907d8..892cea0a3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,8 +7,10 @@ --- ### Before submitting a *pull request* make sure you have: -- [ ] At least skimmed through [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-support-for-a-new-site) and [youtube-dl coding conventions](https://github.com/ytdl-org/youtube-dl#youtube-dl-coding-conventions) sections - [ ] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests +- [ ] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-support-for-a-new-site) +- [ ] Read [youtube-dl coding conventions](https://github.com/ytdl-org/youtube-dl#youtube-dl-coding-conventions) and adjusted the code to meet them +- [ ] Covered the code with tests (note that PRs without tests will be REJECTED) - [ ] Checked the code with [flake8](https://pypi.python.org/pypi/flake8) ### In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under [Unlicense](http://unlicense.org/). Check one of the following options: |