about summary refs log tree commit diff
path: root/tools
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2018-07-27 12:05:00 -0400
committerRich Felker <dalias@aerifal.cx>2018-07-27 12:05:00 -0400
commit14992d4384990d40f6d3cfb799780fb696d77762 (patch)
tree5eb66dfe33b2908bc387f8801bbfbd1f256596e8 /tools
parent3d8322c7ad659210a4c8770ef455ca729ce7f395 (diff)
downloadmusl-14992d4384990d40f6d3cfb799780fb696d77762.tar.gz
musl-14992d4384990d40f6d3cfb799780fb696d77762.tar.xz
musl-14992d4384990d40f6d3cfb799780fb696d77762.zip
make pthread_attr_init honor defaults set by pthread_setattr_default_np
this fixes a major gap in the intended functionality of
pthread_setattr_default_np. if application/library code creating a
thread does not pass a null attribute pointer to pthread_create, but
sets up an attribute object to change other properties while leaving
the stack alone, the created thread will get a stack with size
DEFAULT_STACK_SIZE. this makes pthread_setattr_default_np useless for
working around stack overflow issues in such applications, and leaves
a major risk of regression if previously-working code switches from
using a null attribute pointer to an attribute object.

this change aligns the behavior more closely with the glibc
pthread_setattr_default_np functionality too, albeit via a different
mechanism. glibc encodes "default" specially in the attribute object
and reads the actual default at thread creation time. with this
commit, we now copy the current default into the attribute object at
pthread_attr_init time, so that applications that query the properties
of the attribute object will see the right values.
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions