about summary refs log tree commit diff
path: root/src/thread
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2018-09-06 11:15:15 -0400
committerRich Felker <dalias@aerifal.cx>2018-09-12 14:34:20 -0400
commitc221d3e5862e249b03aa7569d5fec6389294fb22 (patch)
tree227098b1eefa6036f39a05941632771db54cf2b6 /src/thread
parenteeb6f7742506b08692f745c7f588d046f1aa8214 (diff)
downloadmusl-c221d3e5862e249b03aa7569d5fec6389294fb22.tar.gz
musl-c221d3e5862e249b03aa7569d5fec6389294fb22.tar.xz
musl-c221d3e5862e249b03aa7569d5fec6389294fb22.zip
fix issues from public functions defined without declaration visible
policy is that all public functions which have a public declaration
should be defined in a context where that public declaration is
visible, to avoid preventable type mismatches.

an audit performed using GCC's -Wmissing-declarations turned up the
violations corrected here. in some cases the public header had not
been included; in others, a feature test macro needed to make the
declaration visible had been omitted.

in the case of gethostent and getnetent, the omission seems to have
been intentional, as a hack to admit a single stub definition for both
functions. this kind of hack is no longer acceptable; it's UB and
would not fly with LTO or advanced toolchains. the hack is undone to
make exposure of the declarations possible.
Diffstat (limited to 'src/thread')
-rw-r--r--src/thread/pthread_setattr_default_np.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/thread/pthread_setattr_default_np.c b/src/thread/pthread_setattr_default_np.c
index ffd2712b..88503e34 100644
--- a/src/thread/pthread_setattr_default_np.c
+++ b/src/thread/pthread_setattr_default_np.c
@@ -1,3 +1,4 @@
+#define _GNU_SOURCE
 #include "pthread_impl.h"
 #include <string.h>