about summary refs log tree commit diff
path: root/src/stdio/open_wmemstream.c
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2011-09-04 10:29:04 -0400
committerRich Felker <dalias@aerifal.cx>2011-09-04 10:29:04 -0400
commit7ee3dcb3c603b20fcd4547ffb00e11701c6d1cf4 (patch)
treede55d7b177cbe5f095ac2745e65e5544254fc067 /src/stdio/open_wmemstream.c
parentc88f36f55623124d09f48631974ca38aaec00057 (diff)
downloadmusl-7ee3dcb3c603b20fcd4547ffb00e11701c6d1cf4.tar.gz
musl-7ee3dcb3c603b20fcd4547ffb00e11701c6d1cf4.tar.xz
musl-7ee3dcb3c603b20fcd4547ffb00e11701c6d1cf4.zip
memstreams: fix incorrect handling of file pos > current size
the addition is safe and cannot overflow because both operands are
positive when considered as signed quantities.
Diffstat (limited to 'src/stdio/open_wmemstream.c')
-rw-r--r--src/stdio/open_wmemstream.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/stdio/open_wmemstream.c b/src/stdio/open_wmemstream.c
index 0db77416..a830b143 100644
--- a/src/stdio/open_wmemstream.c
+++ b/src/stdio/open_wmemstream.c
@@ -30,8 +30,8 @@ static size_t wms_write(FILE *f, const unsigned char *buf, size_t len)
 	struct cookie *c = f->cookie;
 	size_t len2;
 	wchar_t *newbuf;
-	if (len >= c->space - c->pos) {
-		len2 = 2*c->space+1 | c->space+len+1;
+	if (len + c->pos >= c->space) {
+		len2 = 2*c->space+1 | c->pos+len+1;
 		if (len2 > SSIZE_MAX/4) return 0;
 		newbuf = realloc(c->buf, len2*4);
 		if (!newbuf) return 0;