about summary refs log tree commit diff
path: root/src/internal
diff options
context:
space:
mode:
authorSzabolcs Nagy <nsz@port70.net>2020-01-20 20:38:45 +0000
committerRich Felker <dalias@aerifal.cx>2020-02-21 23:42:12 -0500
commitd20558148d8a2c52229b02668627697e83ca3840 (patch)
treee4f3373bb8649db621bfeb871ed335e13886b343 /src/internal
parentb3797d3b2e10e6fff2a6b04af917e61e95838b08 (diff)
downloadmusl-d20558148d8a2c52229b02668627697e83ca3840.tar.gz
musl-d20558148d8a2c52229b02668627697e83ca3840.tar.xz
musl-d20558148d8a2c52229b02668627697e83ca3840.zip
math: fix sinh overflows in non-nearest rounding
The final rounding operation should be done with the correct sign
otherwise huge results may incorrectly get rounded to or away from
infinity in upward or downward rounding modes.

This affected sinh and sinhf which set the sign on the result after
a potentially overflowing mul. There may be other non-nearest rounding
issues, but this was a known long standing issue with large ulp error
(depending on how ulp is defined near infinity).

The fix should have no effect on sinh and sinhf performance but may
have a tiny effect on cosh and coshf.
Diffstat (limited to 'src/internal')
-rw-r--r--src/internal/libm.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/internal/libm.h b/src/internal/libm.h
index b5bd26b8..7533f6ba 100644
--- a/src/internal/libm.h
+++ b/src/internal/libm.h
@@ -236,13 +236,13 @@ hidden int    __rem_pio2(double,double*);
 hidden double __sin(double,double,int);
 hidden double __cos(double,double);
 hidden double __tan(double,double,int);
-hidden double __expo2(double);
+hidden double __expo2(double,double);
 
 hidden int    __rem_pio2f(float,double*);
 hidden float  __sindf(double);
 hidden float  __cosdf(double);
 hidden float  __tandf(double,int);
-hidden float  __expo2f(float);
+hidden float  __expo2f(float,float);
 
 hidden int __rem_pio2l(long double, long double *);
 hidden long double __sinl(long double, long double, int);