about summary refs log tree commit diff
path: root/include/getopt.h
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2019-12-22 11:20:44 -0500
committerRich Felker <dalias@aerifal.cx>2019-12-22 11:20:44 -0500
commit3f959f6f76f16b7d954a6d8a134f3c30228d3be0 (patch)
treef8801aace9ef433e36729ab4c76300f58f767e52 /include/getopt.h
parent4d706410779f399e5969439f6005abcee553b01d (diff)
downloadmusl-3f959f6f76f16b7d954a6d8a134f3c30228d3be0.tar.gz
musl-3f959f6f76f16b7d954a6d8a134f3c30228d3be0.tar.xz
musl-3f959f6f76f16b7d954a6d8a134f3c30228d3be0.zip
fix elf_prstatus regression on time64, existing wrong definition on x32
the elf_prstatus structure is used in core dumps, and the timeval
structures in it are longs matching the elf class, *not* the kernel
"old timeval" for the arch. this means using timeval here for x32 was
always wrong, despite kernel uapi headers and glibc also exposing it
this way, and of course it's wrong for any arch with 64-bit time_t.

rather than just changing the type on affected archs, use a tagless
struct containing long tv_sec and tv_usec members in place of the
timevals. this intentionally breaks use of them as timevals (e.g.
assignment, passing address, etc.) on 64-bit archs as well so that any
usage unsafe for 32-bit archs is caught even in software that only
gets tested on 64-bit archs. from what I could gather, there is not
any software using these members anyway. the only reason they need to
be fixed to begin with is that the only members which are commonly
used, the saved registers, follow the time members and have the wrong
offset if the time members are sized incorrectly.
Diffstat (limited to 'include/getopt.h')
0 files changed, 0 insertions, 0 deletions