about summary refs log tree commit diff
diff options
context:
space:
mode:
authorRich Felker <dalias@aerifal.cx>2015-12-15 23:18:38 -0500
committerRich Felker <dalias@aerifal.cx>2015-12-15 23:18:38 -0500
commit0d58bf2d6078dd486951cdeb24790043eb171081 (patch)
tree86d016a2a73a326dd39d1cb1d495ec57e95ff390
parent3abb094d19ca4c7c4adcf373d971fb5aa05c5252 (diff)
downloadmusl-0d58bf2d6078dd486951cdeb24790043eb171081.tar.gz
musl-0d58bf2d6078dd486951cdeb24790043eb171081.tar.xz
musl-0d58bf2d6078dd486951cdeb24790043eb171081.zip
remove visibility suppression by SHARED macro in mips and x32 arch files
commit 8a8fdf6398b85c99dffb237e47fa577e2ddc9e77 was intended to remove
all such usage, but these arch-specific files were overlooked, leading
to inconsistent declarations and definitions.
-rw-r--r--arch/mips/syscall_arch.h2
-rw-r--r--arch/x32/src/syscall_cp_fixup.c4
2 files changed, 0 insertions, 6 deletions
diff --git a/arch/mips/syscall_arch.h b/arch/mips/syscall_arch.h
index 1b1179c4..e74e0ad0 100644
--- a/arch/mips/syscall_arch.h
+++ b/arch/mips/syscall_arch.h
@@ -3,9 +3,7 @@
 ((union { long long ll; long l[2]; }){ .ll = x }).l[1]
 #define __SYSCALL_LL_O(x) 0, __SYSCALL_LL_E((x))
 
-#ifdef SHARED
 __attribute__((visibility("hidden")))
-#endif
 long (__syscall)(long, ...);
 
 #define SYSCALL_RLIM_INFINITY (-1UL/2)
diff --git a/arch/x32/src/syscall_cp_fixup.c b/arch/x32/src/syscall_cp_fixup.c
index deb01ee9..b1f3a382 100644
--- a/arch/x32/src/syscall_cp_fixup.c
+++ b/arch/x32/src/syscall_cp_fixup.c
@@ -1,8 +1,6 @@
 #include <sys/syscall.h>
 
-#ifdef SHARED
 __attribute__((__visibility__("hidden")))
-#endif
 long __syscall_cp_internal(volatile void*, long long, long long, long long, long long,
                              long long, long long, long long);
 
@@ -14,9 +12,7 @@ struct __timespec_kernel { long long tv_sec; long long tv_nsec; };
 	ts->tv_nsec = __tsc(X)->tv_nsec; \
 	(X) = (unsigned long)ts; } } while(0)
 
-#ifdef SHARED
 __attribute__((__visibility__("hidden")))
-#endif
 long __syscall_cp_asm (volatile void * foo, long long n, long long a1, long long a2, long long a3,
 	                     long long a4, long long a5, long long a6)
 {