blob: b0b30340ccf90f62c0f5566398cec93b5573414e (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
|
#!/bin/bash
# Copyright (C) 2023-2024 Free Software Foundation, Inc.
# This file is part of the GNU C Library.
# The GNU C Library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
# License as published by the Free Software Foundation; either
# version 2.1 of the License, or (at your option) any later version.
# The GNU C Library is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# Lesser General Public License for more details.
# You should have received a copy of the GNU Lesser General Public
# License along with the GNU C Library; if not, see
# <https://www.gnu.org/licenses/>.
# This script checks to see that all Makefiles in the source tree
# conform to the sorted variable rules as defined by:
# scripts/sort-makefile-lines.py.
# Any difference is an error and should be corrected e.g. the lines
# reordered to sort correctly.
# The intent with this check is to ensure that changes made by
# developers match the expected format for the project.
export LC_ALL=C
tmpfile="$(mktemp)"
cleanup () {
rm -f -- "$tmpfile"
}
trap cleanup 0
PYTHON=$1
# Absolute or relative path to the source directory.
srcdir=$2
# Must specify $PYTHON.
if [ -z "$PYTHON" ]; then
echo 'Please specify $PYTHON interpreter'
exit 1
fi
# Absolute or relative $srcdir must exist and be a directory.
if [ ! -d "$srcdir" ]; then
echo 'Please specify $srcdir in which to look for Makefiles'
exit 1
fi
linted=0
failed=0
for mfile in `find "$srcdir" -name Makefile`; do
$PYTHON "${srcdir}/scripts/sort-makefile-lines.py" < "$mfile" > "$tmpfile"
# Printed the expected -> actual difference on error.
if ! diff -u --label "$mfile.expected" "$tmpfile" "$mfile"; then
failed=$((failed+1))
fi
linted=$((linted+1))
done
# Must have linted at least the top-level Makefile.
if [ $linted -lt 1 ]; then
echo "Did not lint any Makefiles!"
exit 1
fi
if [ $failed -gt 0 ]; then
echo "---"
echo "Tested $linted Makefiles and $failed were incorrectly sorted"
echo 'Please use `patch -R -pN` and the output above to correct the sorting'
exit 1
fi
# All Makefiles linted clean.
exit 0
|
