about summary refs log tree commit diff
path: root/sysdeps
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2021-07-09 20:09:14 +0200
committerFlorian Weimer <fweimer@redhat.com>2021-07-09 20:09:14 +0200
commit7c241325d67af9e24ff03d4c6f6280c17ea181f8 (patch)
tree5667f94ae80c6e75dc1bac29ab4c51d48cfad084 /sysdeps
parentdc76a059fded7a203c82dbb91d4fc1f43d3250db (diff)
downloadglibc-7c241325d67af9e24ff03d4c6f6280c17ea181f8.tar.gz
glibc-7c241325d67af9e24ff03d4c6f6280c17ea181f8.tar.xz
glibc-7c241325d67af9e24ff03d4c6f6280c17ea181f8.zip
Force building with -fno-common
As a result, is not necessary to specify __attribute__ ((nocommon))
on individual definitions.

GCC 10 defaults to -fno-common on all architectures except ARC,
but this change is compatible with older GCC versions and ARC, too.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'sysdeps')
-rw-r--r--sysdeps/nptl/dl-tls_init_tp.c4
-rw-r--r--sysdeps/powerpc/nofpu/sim-full.c8
-rw-r--r--sysdeps/unix/sysv/linux/timer_routines.c5
3 files changed, 8 insertions, 9 deletions
diff --git a/sysdeps/nptl/dl-tls_init_tp.c b/sysdeps/nptl/dl-tls_init_tp.c
index c3349dd14c..ca494dd3a5 100644
--- a/sysdeps/nptl/dl-tls_init_tp.c
+++ b/sysdeps/nptl/dl-tls_init_tp.c
@@ -23,11 +23,11 @@
 #include <tls.h>
 
 #ifndef __ASSUME_SET_ROBUST_LIST
-bool __nptl_set_robust_list_avail __attribute__ ((nocommon));
+bool __nptl_set_robust_list_avail;
 rtld_hidden_data_def (__nptl_set_robust_list_avail)
 #endif
 
-bool __nptl_initial_report_events __attribute__ ((nocommon));
+bool __nptl_initial_report_events;
 rtld_hidden_def (__nptl_initial_report_events)
 
 #ifdef SHARED
diff --git a/sysdeps/powerpc/nofpu/sim-full.c b/sysdeps/powerpc/nofpu/sim-full.c
index 1867e8d305..ab1e97d9ed 100644
--- a/sysdeps/powerpc/nofpu/sim-full.c
+++ b/sysdeps/powerpc/nofpu/sim-full.c
@@ -22,18 +22,18 @@
 #include "soft-supp.h"
 
 /* Thread-local to store sticky exceptions.  */
-__thread int __sim_exceptions_thread __attribute__ ((nocommon));
+__thread int __sim_exceptions_thread;
 libc_hidden_tls_def (__sim_exceptions_thread);
 
 /* By default, no exceptions should trap.  */
 __thread int __sim_disabled_exceptions_thread = 0xffffffff;
 libc_hidden_tls_def (__sim_disabled_exceptions_thread);
 
-__thread int __sim_round_mode_thread __attribute__ ((nocommon));
+__thread int __sim_round_mode_thread;
 libc_hidden_tls_def (__sim_round_mode_thread);
 
 #if SIM_GLOBAL_COMPAT
-int __sim_exceptions_global __attribute__ ((nocommon));
+int __sim_exceptions_global;
 libc_hidden_data_def (__sim_exceptions_global);
 SIM_COMPAT_SYMBOL (__sim_exceptions_global, __sim_exceptions);
 
@@ -42,7 +42,7 @@ libc_hidden_data_def (__sim_disabled_exceptions_global);
 SIM_COMPAT_SYMBOL (__sim_disabled_exceptions_global,
 		   __sim_disabled_exceptions);
 
-int __sim_round_mode_global __attribute__ ((nocommon));
+int __sim_round_mode_global;
 libc_hidden_data_def (__sim_round_mode_global);
 SIM_COMPAT_SYMBOL (__sim_round_mode_global, __sim_round_mode);
 #endif
diff --git a/sysdeps/unix/sysv/linux/timer_routines.c b/sysdeps/unix/sysv/linux/timer_routines.c
index 30ad32b4fc..02bad0384e 100644
--- a/sysdeps/unix/sysv/linux/timer_routines.c
+++ b/sysdeps/unix/sysv/linux/timer_routines.c
@@ -107,12 +107,11 @@ timer_helper_thread (void *arg)
 
 
 /* Control variable for helper thread creation.  */
-pthread_once_t __timer_helper_once __attribute__ ((nocommon))
-  = PTHREAD_ONCE_INIT;
+pthread_once_t __timer_helper_once = PTHREAD_ONCE_INIT;
 
 
 /* TID of the helper thread.  */
-pid_t __timer_helper_tid __attribute__ ((nocommon));
+pid_t __timer_helper_tid;
 
 
 /* Reset variables so that after a fork a new helper thread gets started.  */