diff options
author | Martin Sebor <msebor@redhat.com> | 2021-05-06 10:56:25 -0600 |
---|---|---|
committer | Martin Sebor <msebor@redhat.com> | 2021-05-06 11:01:05 -0600 |
commit | 26492c0a14966c32c43cd6ca1d0dca5e62c6cfef (patch) | |
tree | 1d2aceda8438c17113e02f86f2c8c31d58ac7f79 /sysdeps/unix/sysv/linux | |
parent | 3f0808ef4c872afeade0e323c024ac59ec90fc2b (diff) | |
download | glibc-26492c0a14966c32c43cd6ca1d0dca5e62c6cfef.tar.gz glibc-26492c0a14966c32c43cd6ca1d0dca5e62c6cfef.tar.xz glibc-26492c0a14966c32c43cd6ca1d0dca5e62c6cfef.zip |
Annotate additional APIs with GCC attribute access.
This change continues the improvements to compile-time out of bounds checking by decorating more APIs with either attribute access, or by explicitly providing the array bound in APIs such as tmpnam() that expect arrays of some minimum size as arguments. (The latter feature is new in GCC 11.) The only effects of the attribute and/or the array bound is to check and diagnose calls to the functions that fail to provide a sufficient number of elements, and the definitions of the functions that access elements outside the specified bounds. (There is no interplay with _FORTIFY_SOURCE here yet.) Tested with GCC 7 through 11 on x86_64-linux.
Diffstat (limited to 'sysdeps/unix/sysv/linux')
-rw-r--r-- | sysdeps/unix/sysv/linux/if_index.c | 2 | ||||
-rw-r--r-- | sysdeps/unix/sysv/linux/test-errno-linux.c | 12 |
2 files changed, 13 insertions, 1 deletions
diff --git a/sysdeps/unix/sysv/linux/if_index.c b/sysdeps/unix/sysv/linux/if_index.c index 70a16a69c4..d38340bb64 100644 --- a/sysdeps/unix/sysv/linux/if_index.c +++ b/sysdeps/unix/sysv/linux/if_index.c @@ -215,7 +215,7 @@ libc_hidden_weak (if_nameindex) char * -__if_indextoname (unsigned int ifindex, char *ifname) +__if_indextoname (unsigned int ifindex, char ifname[IF_NAMESIZE]) { /* We may be able to do the conversion directly, rather than searching a list. This ioctl is not present in kernels before version 2.1.50. */ diff --git a/sysdeps/unix/sysv/linux/test-errno-linux.c b/sysdeps/unix/sysv/linux/test-errno-linux.c index d63836e584..65fb90f9fc 100644 --- a/sysdeps/unix/sysv/linux/test-errno-linux.c +++ b/sysdeps/unix/sysv/linux/test-errno-linux.c @@ -44,6 +44,7 @@ #include <sys/time.h> #include <sys/types.h> #include <sys/wait.h> +#include <libc-diag.h> /* This is not an exhaustive test: only system calls that can be persuaded to fail with a consistent error code and no side effects @@ -171,7 +172,18 @@ do_test (void) allocation. */ fails |= test_wrp2 (LIST (EINVAL, ENOMEM), mlock, (void *) -1, 1); fails |= test_wrp (EINVAL, nanosleep, &ts, &ts); + + DIAG_POP_NEEDS_COMMENT; + +#if __GNUC_PREREQ (9, 0) + /* Suppress valid GCC warning: + 'poll' specified size 18446744073709551608 exceeds maximum object size + */ + DIAG_IGNORE_NEEDS_COMMENT (9, "-Wstringop-overflow="); +#endif fails |= test_wrp (EINVAL, poll, &pollfd, -1, 0); + DIAG_POP_NEEDS_COMMENT; + /* quotactl returns ENOSYS for kernels not configured with CONFIG_QUOTA, and may return EPERM if called within certain types of containers. Linux 5.4 added additional argument validation |