about summary refs log tree commit diff
path: root/sysdeps/unix/confstr.h
diff options
context:
space:
mode:
authorH.J. Lu <hjl.tools@gmail.com>2024-05-25 05:13:41 -0700
committerH.J. Lu <hjl.tools@gmail.com>2024-05-27 06:52:45 -0700
commitf981bf6b9db87e0732b46bfe92fdad4d363225e8 (patch)
tree83ca2629f374ce38a59ccffbe21bf02227756778 /sysdeps/unix/confstr.h
parentab46c6ba6cc43b18daea6f197030e19303c9f012 (diff)
downloadglibc-f981bf6b9db87e0732b46bfe92fdad4d363225e8.tar.gz
glibc-f981bf6b9db87e0732b46bfe92fdad4d363225e8.tar.xz
glibc-f981bf6b9db87e0732b46bfe92fdad4d363225e8.zip
parse_fdinfo: Don't advance pointer twice [BZ #31798]
pidfd_getpid.c has

      /* Ignore invalid large values.  */
      if (INT_MULTIPLY_WRAPV (10, n, &n)
          || INT_ADD_WRAPV (n, *l++ - '0', &n))
        return -1;

For GCC older than GCC 7, INT_ADD_WRAPV(a, b, r) is defined as

   _GL_INT_OP_WRAPV (a, b, r, +, _GL_INT_ADD_RANGE_OVERFLOW)

and *l++ - '0' is evaluated twice.  Fix BZ #31798 by moving "l++" out of
the if statement.  Tested with GCC 6.4 and GCC 14.1.

Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
Diffstat (limited to 'sysdeps/unix/confstr.h')
0 files changed, 0 insertions, 0 deletions