about summary refs log tree commit diff
path: root/sysdeps/s390/s390-32/dl-sysdep.h
diff options
context:
space:
mode:
authorSiddhesh Poyarekar <siddhesh@redhat.com>2014-11-12 19:30:24 +0530
committerSiddhesh Poyarekar <siddhesh@redhat.com>2014-11-12 19:42:59 +0530
commit533bb7c2ae156ff2d49b2e0b20b33810ba5e2721 (patch)
treeaaeb627afb1e90b79e161e4d325b633064163168 /sysdeps/s390/s390-32/dl-sysdep.h
parentfffa1cf8a7f95830d488d5fc6bf73cb9599143f4 (diff)
downloadglibc-533bb7c2ae156ff2d49b2e0b20b33810ba5e2721.tar.gz
glibc-533bb7c2ae156ff2d49b2e0b20b33810ba5e2721.tar.xz
glibc-533bb7c2ae156ff2d49b2e0b20b33810ba5e2721.zip
Fix stack alignment when loader is invoked directly
The s390 ABI requires the stack pointer to be aligned at 8-bytes.
When a program is invoked as an argument to the dynamic linker,
_dl_start_user adjusts the stack to remove the dynamic linker
arguments so that the program sees only its name and arguments.  This
may result in the stack being misaligned since each argument shift is
only a word and not a double-word.

This is now fixed shifting argv and envp down instead of shifting argc
up and reclaiming the stack.  This requires _dl_argv to be adjusted
and hence, is no longer relro.
Diffstat (limited to 'sysdeps/s390/s390-32/dl-sysdep.h')
-rw-r--r--sysdeps/s390/s390-32/dl-sysdep.h23
1 files changed, 23 insertions, 0 deletions
diff --git a/sysdeps/s390/s390-32/dl-sysdep.h b/sysdeps/s390/s390-32/dl-sysdep.h
new file mode 100644
index 0000000000..b992778c60
--- /dev/null
+++ b/sysdeps/s390/s390-32/dl-sysdep.h
@@ -0,0 +1,23 @@
+/* System-specific settings for dynamic linker code.  S/390 version.
+   Copyright (C) 2014 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library.  If not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#include_next <dl-sysdep.h>
+
+/* _dl_argv cannot be attribute_relro, because _dl_start_user
+   might write into it after _dl_start returns.  */
+#define DL_ARGV_NOT_RELRO 1