diff options
| author | Fangrui Song <maskray@google.com> | 2022-04-26 09:26:22 -0700 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2022-04-26 09:26:22 -0700 |
| commit | 098a657fe449a217cf65c5270d5fbc8d40b5b4e6 (patch) | |
| tree | 3721fb17b7746c4dfbe411439f84699f7e6c17a3 /sysdeps/mips | |
| parent | e465d97653311c3687aee49de782177353acfe86 (diff) | |
| download | glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.tar.gz glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.tar.xz glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.zip | |
elf: Replace PI_STATIC_AND_HIDDEN with opposite HIDDEN_VAR_NEEDS_DYNAMIC_RELOC
PI_STATIC_AND_HIDDEN indicates whether accesses to internal linkage variables and hidden visibility variables in a shared object (ld.so) need dynamic relocations (usually R_*_RELATIVE). PI (position independent) in the macro name is a misnomer: a code sequence using GOT is typically position-independent as well, but using dynamic relocations does not meet the requirement. Not defining PI_STATIC_AND_HIDDEN is legacy and we expect that all new ports will define PI_STATIC_AND_HIDDEN. Current ports defining PI_STATIC_AND_HIDDEN are more than the opposite. Change the configure default. No functional change. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diffstat (limited to 'sysdeps/mips')
| -rw-r--r-- | sysdeps/mips/configure | 2 | ||||
| -rw-r--r-- | sysdeps/mips/configure.ac | 2 |
2 files changed, 3 insertions, 1 deletions
diff --git a/sysdeps/mips/configure b/sysdeps/mips/configure index 4e13248c03..3f4d9e9759 100644 --- a/sysdeps/mips/configure +++ b/sysdeps/mips/configure @@ -1,6 +1,8 @@ # This file is generated from configure.ac by Autoconf. DO NOT EDIT! # Local configure fragment for sysdeps/mips. +$as_echo "#define HIDDEN_VAR_NEEDS_DYNAMIC_RELOC 1" >>confdefs.h + diff --git a/sysdeps/mips/configure.ac b/sysdeps/mips/configure.ac index bcbdaffd9f..d3cd780d78 100644 --- a/sysdeps/mips/configure.ac +++ b/sysdeps/mips/configure.ac @@ -3,7 +3,7 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory. dnl No MIPS GCC supports accessing static and hidden symbols in an dnl position independent way. -dnl AC_DEFINE(PI_STATIC_AND_HIDDEN) +AC_DEFINE(HIDDEN_VAR_NEEDS_DYNAMIC_RELOC) AC_CACHE_CHECK([whether the compiler is using the 2008 NaN encoding], libc_cv_mips_nan2008, [AC_EGREP_CPP(yes, [dnl |