diff options
author | Joseph Myers <joseph@codesourcery.com> | 2016-05-24 17:44:46 +0000 |
---|---|---|
committer | Joseph Myers <joseph@codesourcery.com> | 2016-05-24 17:44:46 +0000 |
commit | 876c5bd30cf44ab47ee46c08d06e6ba9ab2b338f (patch) | |
tree | 11e8750a8d86c7d5de13e8b2f8bc96f86943dd19 /sysdeps/ieee754/dbl-64/wordsize-64/s_floor.c | |
parent | ac2cc6f021ae4503f1d51c2379d5551a8b05812b (diff) | |
download | glibc-876c5bd30cf44ab47ee46c08d06e6ba9ab2b338f.tar.gz glibc-876c5bd30cf44ab47ee46c08d06e6ba9ab2b338f.tar.xz glibc-876c5bd30cf44ab47ee46c08d06e6ba9ab2b338f.zip |
Do not raise "inexact" from generic floor (bug 15479).
C99 and C11 allow but do not require ceil, floor, round and trunc to raise the "inexact" exception for noninteger arguments. TS 18661-1 requires that this exception not be raised by these functions. This aligns them with general IEEE semantics, where "inexact" is only raised if the final step of rounding the infinite-precision result to the result type is inexact; for these functions, the infinite-precision integer result is always representable in the result type, so "inexact" should never be raised. The generic implementations of ceil, floor and round functions contain code to force "inexact" to be raised. This patch removes it for floor functions to align them with TS 18661-1 in this regard. Note that some architecture-specific versions may still raise "inexact", so the tests are not updated and the bug is not yet fixed. Tested for x86_64, x86 and mips64. [BZ #15479] * sysdeps/ieee754/dbl-64/s_floor.c: Do not mention "inexact" exception in comment. (huge): Remove variable. (__floor): Do not force "inexact" exception. * sysdeps/ieee754/dbl-64/wordsize-64/s_floor.c: Do not mention "inexact" exception in comment. (huge): Remove variable. (__floor): Do not force "inexact" exception. * sysdeps/ieee754/flt-32/s_floorf.c: Do not mention "inexact" exception in comment. (huge): Remove variable. (__floorf): Do not force "inexact" exception. * sysdeps/ieee754/ldbl-128/s_floorl.c: Do not mention "inexact" exception in comment. (huge): Remove variable. (__floorl): Do not force "inexact" exception.
Diffstat (limited to 'sysdeps/ieee754/dbl-64/wordsize-64/s_floor.c')
-rw-r--r-- | sysdeps/ieee754/dbl-64/wordsize-64/s_floor.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/sysdeps/ieee754/dbl-64/wordsize-64/s_floor.c b/sysdeps/ieee754/dbl-64/wordsize-64/s_floor.c index b7ed14bfa2..8d514f23bc 100644 --- a/sysdeps/ieee754/dbl-64/wordsize-64/s_floor.c +++ b/sysdeps/ieee754/dbl-64/wordsize-64/s_floor.c @@ -39,12 +39,8 @@ * Return x rounded toward -inf to integral value * Method: * Bit twiddling. - * Exception: - * Inexact flag raised if x not equal to floor(x). */ -static const double huge = 1.0e300; - double __floor (double x) @@ -53,15 +49,14 @@ __floor (double x) EXTRACT_WORDS64(i0,x); int32_t j0 = ((i0>>52)&0x7ff)-0x3ff; if(__builtin_expect(j0<52, 1)) { - if(j0<0) { /* raise inexact if x != 0 */ - math_force_eval(huge+x);/* return 0*sign(x) if |x|<1 */ + if(j0<0) { + /* return 0*sign(x) if |x|<1 */ if(i0>=0) {i0=0;} else if((i0&0x7fffffffffffffffl)!=0) { i0=0xbff0000000000000l;} } else { uint64_t i = (0x000fffffffffffffl)>>j0; if((i0&i)==0) return x; /* x is integral */ - math_force_eval(huge+x); /* raise inexact flag */ if(i0<0) i0 += (0x0010000000000000l)>>j0; i0 &= (~i); } |