diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-01-05 19:43:25 -0200 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-02-06 10:24:17 -0200 |
| commit | f2d7f23a300f57e36cd849ce80a93ccbcebd9968 (patch) | |
| tree | e4ec9e08573b34712e7af81603bce242f39b4d53 /sysdeps/i386/strtok_r.S | |
| parent | 841a67a0ade3ea9e3d10c044524a199fa608cc7e (diff) | |
| download | glibc-f2d7f23a300f57e36cd849ce80a93ccbcebd9968.tar.gz glibc-f2d7f23a300f57e36cd849ce80a93ccbcebd9968.tar.xz glibc-f2d7f23a300f57e36cd849ce80a93ccbcebd9968.zip | |
Remove i686, x86_64, and powerpc strtok implementations
Based on comments on previous attempt to address BZ#16640 [1], the idea is not support invalid use of strtok (the original bug report proposal). This leader to a new strtok optimized strtok implementation [2]. The idea of this patch is to fix BZ#16640 to align all the implementations to a same contract. However, with newer strtok code it is better to get remove the old assembly ones instead of fix them. For x86 is a gain in all cases since the new implementation can potentially use sse2/sse42 implementation for strspn and strcspn. This shows a better performance on both i686 and x86_64 using the string benchtests. On powerpc64 the gains are mixed, where only for larger inputs or keys some gains are showns (based on benchtest it seems that it shows some gains for keys larger than 10 and inputs larger than 32). I would prefer to remove the optimized implementation based on first code simplicity and second because some more gain could be optimized using a better optimized strcspn/strspn code (as for x86). However if powerpc arch maintainers prefer I can send a v2 with the assembly code adjusted instead. Checked on x86_64-linux-gnu, i686-linux-gnu, and powerpc64le-linux-gnu. [BZ #16640] * sysdeps/i386/i686/strtok.S: Remove file. * sysdeps/i386/i686/strtok_r.S: Likewise. * sysdeps/i386/strtok.S: Likewise. * sysdeps/i386/strtok_r.S: Likewise. * sysdeps/powerpc/powerpc64/strtok.S: Likewise. * sysdeps/powerpc/powerpc64/strtok_r.S: Likewise. * sysdeps/x86_64/strtok.S: Likewise. * sysdeps/x86_64/strtok_r.S: Likewise. [1] https://sourceware.org/ml/libc-alpha/2016-10/msg00411.html [2] https://sourceware.org/ml/libc-alpha/2016-12/msg00461.html
Diffstat (limited to 'sysdeps/i386/strtok_r.S')
| -rw-r--r-- | sysdeps/i386/strtok_r.S | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/sysdeps/i386/strtok_r.S b/sysdeps/i386/strtok_r.S deleted file mode 100644 index 508729370a..0000000000 --- a/sysdeps/i386/strtok_r.S +++ /dev/null @@ -1,5 +0,0 @@ -#define FUNCTION __strtok_r -#define USE_AS_STRTOK_R 1 -#include <sysdeps/i386/strtok.S> -weak_alias (__strtok_r, strtok_r) -strong_alias (__strtok_r, __GI___strtok_r) |