diff options
author | Raoni Fassina Firmino <raoni@linux.ibm.com> | 2021-01-27 16:23:05 -0300 |
---|---|---|
committer | Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> | 2021-01-28 13:57:50 -0300 |
commit | 5ee506ed35a2c9184bcb1fb5e79b6cceb9bb0dd1 (patch) | |
tree | 55348527f5c9619a6e8e9ee957f824da5fb6cbae /sysdeps/alpha/fpu/fesetmode.c | |
parent | 757a14b5ac7c736c759605f4b674cae28d752116 (diff) | |
download | glibc-5ee506ed35a2c9184bcb1fb5e79b6cceb9bb0dd1.tar.gz glibc-5ee506ed35a2c9184bcb1fb5e79b6cceb9bb0dd1.tar.xz glibc-5ee506ed35a2c9184bcb1fb5e79b6cceb9bb0dd1.zip |
powerpc64: Workaround sigtramp vdso return call
A not so recent kernel change[1] changed how the trampoline `__kernel_sigtramp_rt64` is used to call signal handlers. This was exposed on the test misc/tst-sigcontext-get_pc Before kernel 5.9, the kernel set LR to the trampoline address and jumped directly to the signal handler, and at the end the signal handler, as any other function, would `blr` to the address set. In other words, the trampoline was executed just at the end of the signal handler and the only thing it did was call sigreturn. But since kernel 5.9 the kernel set CTRL to the signal handler and calls to the trampoline code, the trampoline then `bctrl` to the address in CTRL, setting the LR to the next instruction in the middle of the trampoline, when the signal handler returns, the rest of the trampoline code executes the same code as before. Here is the full trampoline code as of kernel 5.11.0-rc5 for reference: V_FUNCTION_BEGIN(__kernel_sigtramp_rt64) .Lsigrt_start: bctrl /* call the handler */ addi r1, r1, __SIGNAL_FRAMESIZE li r0,__NR_rt_sigreturn sc .Lsigrt_end: V_FUNCTION_END(__kernel_sigtramp_rt64) This new behavior breaks how `backtrace()` uses to detect the trampoline frame to correctly reconstruct the stack frame when it is called from inside a signal handling. This workaround rely on the fact that the trampoline code is at very least two (maybe 3?) instructions in size (as it is in the 32 bits version, only on `li` and `sc`), so it is safe to check the return address be in the range __kernel_sigtramp_rt64 .. + 4. [1] subject: powerpc/64/signal: Balance return predictor stack in signal trampoline commit: 0138ba5783ae0dcc799ad401a1e8ac8333790df9 url: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0138ba5783ae0dcc799ad401a1e8ac8333790df9 Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diffstat (limited to 'sysdeps/alpha/fpu/fesetmode.c')
0 files changed, 0 insertions, 0 deletions