about summary refs log tree commit diff
path: root/support/support_process_state.c
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2020-04-02 17:09:36 +0200
committerFlorian Weimer <fweimer@redhat.com>2020-04-03 16:26:10 +0200
commitcea56af185eae45b1f0963351e3d4daa1cbde521 (patch)
tree2fca166caab3aaf9ce9f07bb719d0546cff3e4d2 /support/support_process_state.c
parent17fd707f88c5531972c980a4f4567ba6c7f84067 (diff)
downloadglibc-cea56af185eae45b1f0963351e3d4daa1cbde521.tar.gz
glibc-cea56af185eae45b1f0963351e3d4daa1cbde521.tar.xz
glibc-cea56af185eae45b1f0963351e3d4daa1cbde521.zip
support: Change xgetline to return 0 on EOF
The advantage is that the buffer will always contain the number
of characters as returned from the function, which allows one to use
a sequence like

  /* No more audit module output.  */
  line_length = xgetline (&buffer, &buffer_length, fp);
  TEST_COMPARE_BLOB ("", 0, buffer, line_length);

to check for an expected EOF, while also reporting any unexpected
extra data encountered.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'support/support_process_state.c')
-rw-r--r--support/support_process_state.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/support/support_process_state.c b/support/support_process_state.c
index 76dc798728..e303c78fc8 100644
--- a/support/support_process_state.c
+++ b/support/support_process_state.c
@@ -59,7 +59,7 @@ support_process_state_wait (pid_t pid, enum support_process_state state)
   for (;;)
     {
       char cur_state = -1;
-      while (xgetline (&line, &linesiz, fstatus) != -1)
+      while (xgetline (&line, &linesiz, fstatus) > 0)
 	if (strncmp (line, "State:", strlen ("State:")) == 0)
 	  {
 	    TEST_COMPARE (sscanf (line, "%*s %c", &cur_state), 1);