diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-01-05 10:07:24 -0200 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2017-01-05 15:54:13 -0200 |
| commit | 38765ab68f329fd84a5984decc8953f8c89d6e5c (patch) | |
| tree | f5796bc5f6881805b7f9b2e02d3734a03bf03ed9 /string/Makefile | |
| parent | 983a9637f730fa265e228509d090c4c5f031d713 (diff) | |
| download | glibc-38765ab68f329fd84a5984decc8953f8c89d6e5c.tar.gz glibc-38765ab68f329fd84a5984decc8953f8c89d6e5c.tar.xz glibc-38765ab68f329fd84a5984decc8953f8c89d6e5c.zip | |
Use fortify macros for b{zero,copy} along decl from strings.h
As described in BZ#20558, bzero and bcopy declaration can only benefit from fortified macros when decl came from string.h and when __USE_MISC is defined (default behaviour). This is due no standard includes those functions in string.h, so they are only declared if __USE_MISC is defined (as pointed out in comment 4). However fortification should be orthogona to other features test macros, i.e, any function should be fortified if that function is declared. To fix this behavior, the patch moved the bzero, bcopy, and __explicit_bzero_chk to a common header (string/bits/strings_fortified.h) and explicit fortified inclusion macros similar to string.h is added on strings.h. This allows to get fortified declarions by only including strings.h. Checked on x86_64-linux-gnu and along on a bootstrap installation to check if the fortified are correctly triggered with example from bug report. [BZ #20558] * string/bits/string3.h [__USE_MISC] (bcopy): Move to strings_fortified.h. [__USE_MISC] (bzero): Likewise. [__USE_MISC] (explicit_bzero): Likewise. * string/strings.h: Include strings_fortified.h. * string/Makefile (headers): Add strings_fortified.h. * string/bits/strings_fortified.h: New file. * include/bits/strings_fortified.h: Likewise.
Diffstat (limited to 'string/Makefile')
| -rw-r--r-- | string/Makefile | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/string/Makefile b/string/Makefile index aaa371f6b6..04e9da951e 100644 --- a/string/Makefile +++ b/string/Makefile @@ -24,7 +24,8 @@ include ../Makeconfig headers := string.h strings.h memory.h endian.h bits/endian.h \ argz.h envz.h byteswap.h bits/byteswap.h bits/byteswap-16.h \ - bits/string.h bits/string2.h bits/string3.h + bits/string.h bits/string2.h bits/string3.h \ + bits/strings_fortified.h routines := strcat strchr strcmp strcoll strcpy strcspn \ strverscmp strdup strndup \ |