about summary refs log tree commit diff
path: root/stdio-common
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>2023-09-27 16:20:13 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2023-09-28 09:41:05 -0300
commitaea4ddb87168d0475777e605f3bb576b0f62b3a2 (patch)
tree66782627d98441ebc8d17119e658e8dd29b83a68 /stdio-common
parent29d4591b07a4da53320e949557c6946c62c26bde (diff)
downloadglibc-aea4ddb87168d0475777e605f3bb576b0f62b3a2.tar.gz
glibc-aea4ddb87168d0475777e605f3bb576b0f62b3a2.tar.xz
glibc-aea4ddb87168d0475777e605f3bb576b0f62b3a2.zip
test-container: Use nftw instead of rm -rf
If the binary to run is 'env', test-containers skips it and adds
any required environment variable on the process envs variables.
This simplifies the required code to spawn new process (no need
to build an env-like program).

However, this is an issue for recursive_remove if there is any
LD_PRELOAD, since test-container will not prepend the loader command
along with required paths.  If the required preloaded library can
not be loaded by the system glibc, the 'post-clean rsync' will
eventually fail.

One example is if system glibc does not support DT_RELR and the
built glibc does, the nss/tst-nss-gai-hv2-canonname test fails
with:

../scripts/evaluate-test.sh nss/tst-nss-gai-hv2-canonname $? false false
86_64-linux-gnu/nss/tst-nss-gai-hv2-canonname.test-result
rm: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_ABI_DT_RELR' not
found (required by x86_64-linux-gnu/malloc/libc_malloc_debug.so)

Instead trying to figure out the required loader arguments on how
to spawn the 'rm -rf', replace the command with a nftw call.

Checked on x86_64-linux-gnu.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Stefan Liebler <stli@linux.ibm.com>
Diffstat (limited to 'stdio-common')
0 files changed, 0 insertions, 0 deletions