Move libc_freeres_ptrs and libc_subfreeres to hidden/weak functions

They are both used by __libc_freeres to free all library malloc
allocated resources to help tooling like mtrace or valgrind with
memory leak tracking.

The current scheme uses assembly markers and linker script entries
to consolidate the free routine function pointers in the RELRO segment
and to be freed buffers in BSS.

This patch changes it to use specific free functions for
libc_freeres_ptrs buffers and call the function pointer array directly
with call_function_static_weak.

It allows the removal of both the internal macros and the linker
script sections.

Checked on x86_64-linux-gnu, i686-linux-gnu, and aarch64-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>

1 files changed, 4 insertions, 1 deletions

diff --git a/shadow/fgetspent.c b/shadow/fgetspent.c
index 76a18bf4fb..541947bad6 100644
--- a/shadow/fgetspent.c
+++ b/shadow/fgetspent.c
@@ -20,6 +20,7 @@
 #include <shadow.h>
 #include <stdio.h>
 #include <stdlib.h>
+#include <set-freeres.h>
 
 
 /* A reasonable size for a buffer to start with.  */
@@ -28,7 +29,7 @@
 /* We need to protect the dynamic buffer handling.  */
 __libc_lock_define_initialized (static, lock);
 
-libc_freeres_ptr (static char *buffer);
+static char *buffer;
 
 /* Read one shadow entry from the given stream.  */
 struct spwd *
@@ -85,3 +86,5 @@ fgetspent (FILE *stream)
 
   return result;
 }
+
+weak_alias (buffer, __libc_fgetspent_freemem_ptr);