about summary refs log tree commit diff
path: root/resolv/nss_dns/dns-network.c
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2016-03-29 12:57:56 +0200
committerGabriel F. T. Gomes <gftg@linux.vnet.ibm.com>2016-05-24 18:08:55 -0300
commit916ef0f69613613e11123657bff127bd26104630 (patch)
tree336643fe692894733c978233530139c7d3fcf362 /resolv/nss_dns/dns-network.c
parentafc4daae0411d10e5d64646d5bafb05075e16151 (diff)
downloadglibc-916ef0f69613613e11123657bff127bd26104630.tar.gz
glibc-916ef0f69613613e11123657bff127bd26104630.tar.xz
glibc-916ef0f69613613e11123657bff127bd26104630.zip
CVE-2016-3075: Stack overflow in _nss_dns_getnetbyname_r [BZ #19879] release/2.20/master
The defensive copy is not needed because the name may not alias the
output buffer.

(cherry picked from commit 317b199b4aff8cfa27f2302ab404d2bb5032b9a4)
(cherry picked from commit f5b3338d70a7a2c626331ac4589b6deb2f610432)
Diffstat (limited to 'resolv/nss_dns/dns-network.c')
-rw-r--r--resolv/nss_dns/dns-network.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/resolv/nss_dns/dns-network.c b/resolv/nss_dns/dns-network.c
index 08cf0a6462..335604adc2 100644
--- a/resolv/nss_dns/dns-network.c
+++ b/resolv/nss_dns/dns-network.c
@@ -118,17 +118,14 @@ _nss_dns_getnetbyname_r (const char *name, struct netent *result,
   } net_buffer;
   querybuf *orig_net_buffer;
   int anslen;
-  char *qbuf;
   enum nss_status status;
 
   if (__res_maybe_init (&_res, 0) == -1)
     return NSS_STATUS_UNAVAIL;
 
-  qbuf = strdupa (name);
-
   net_buffer.buf = orig_net_buffer = (querybuf *) alloca (1024);
 
-  anslen = __libc_res_nsearch (&_res, qbuf, C_IN, T_PTR, net_buffer.buf->buf,
+  anslen = __libc_res_nsearch (&_res, name, C_IN, T_PTR, net_buffer.buf->buf,
 			       1024, &net_buffer.ptr, NULL, NULL, NULL, NULL);
   if (anslen < 0)
     {