about summary refs log tree commit diff
path: root/nscd
diff options
context:
space:
mode:
authorDJ Delorie <dj@redhat.com>2021-02-25 16:08:21 -0500
committerDJ Delorie <dj@redhat.com>2021-03-02 12:32:18 -0500
commitdca565886b5e8bd7966e15f0ca42ee5cff686673 (patch)
tree53fe3258cc1f561b046f3044edd1c44cda8e3c7f /nscd
parentdd1776e3275b89b8ff76e8cfd8cd283f51a9aaaf (diff)
downloadglibc-dca565886b5e8bd7966e15f0ca42ee5cff686673.tar.gz
glibc-dca565886b5e8bd7966e15f0ca42ee5cff686673.tar.xz
glibc-dca565886b5e8bd7966e15f0ca42ee5cff686673.zip
nscd: Fix double free in netgroupcache [BZ #27462]
In commit 745664bd798ec8fd50438605948eea594179fba1 a use-after-free
was fixed, but this led to an occasional double-free.  This patch
tracks the "live" allocation better.

Tested manually by a third party.

Related: RHBZ 1927877

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'nscd')
-rw-r--r--nscd/netgroupcache.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c
index dba6ceec1b..ad2daddafd 100644
--- a/nscd/netgroupcache.c
+++ b/nscd/netgroupcache.c
@@ -248,7 +248,7 @@ addgetnetgrentX (struct database_dyn *db, int fd, request_header *req,
 					     : NULL);
 				    ndomain = (ndomain ? newbuf + ndomaindiff
 					       : NULL);
-				    buffer = newbuf;
+				    *tofreep = buffer = newbuf;
 				  }
 
 				nhost = memcpy (buffer + bufused,
@@ -319,7 +319,7 @@ addgetnetgrentX (struct database_dyn *db, int fd, request_header *req,
 		    else if (status == NSS_STATUS_TRYAGAIN && e == ERANGE)
 		      {
 			buflen *= 2;
-			buffer = xrealloc (buffer, buflen);
+			*tofreep = buffer = xrealloc (buffer, buflen);
 		      }
 		    else if (status == NSS_STATUS_RETURN
 			     || status == NSS_STATUS_NOTFOUND