diff options
author | Florian Weimer <fweimer@redhat.com> | 2021-06-29 22:17:05 +0200 |
---|---|---|
committer | Florian Weimer <fweimer@redhat.com> | 2021-06-29 22:17:08 +0200 |
commit | 3640654575bef7b56840fbadc1a6d6180ea011a7 (patch) | |
tree | 22e94076681604c7264d99394ce655ecf9c87a38 /nptl_db/db-symbols.awk | |
parent | 9dc7dc5708c5c35aeb2e0c594c74b4ba4674aa6d (diff) | |
download | glibc-3640654575bef7b56840fbadc1a6d6180ea011a7.tar.gz glibc-3640654575bef7b56840fbadc1a6d6180ea011a7.tar.xz glibc-3640654575bef7b56840fbadc1a6d6180ea011a7.zip |
nptl_db: Re-use the ELF-to-abilist converter for ABI checking
The previous approach uses readelf -DWs, which does not produce a stable output format (older binutils versions do not include symbol version information). This commit re-uses scripts/abilist.awk with a tweak to include GLIBC_PRIVATE symbols. This awk script is based on objdump -T output, which appears to be stable over time. Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
Diffstat (limited to 'nptl_db/db-symbols.awk')
-rw-r--r-- | nptl_db/db-symbols.awk | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/nptl_db/db-symbols.awk b/nptl_db/db-symbols.awk index fe90d3b435..67034c3e89 100644 --- a/nptl_db/db-symbols.awk +++ b/nptl_db/db-symbols.awk @@ -1,5 +1,5 @@ -# This script processes the output of 'readelf -W -D -s' on the libc.so -# we've just built. It checks for all the symbols used in td_symbol_list. +# This script processes the libc.so abilist (with GLIBC_PRIVATE +# symbols included). It checks for all the symbols used in td_symbol_list. BEGIN { %define DB_MAIN_VARIABLE(name) /* Nothing. */ @@ -12,18 +12,14 @@ BEGIN { in_symtab = 0; } -/Symbol table for image/ { in_symtab=1; next } -NF == 0 { in_symtab=0; next } - -!in_symtab { next } - -NF >= 8 && $7 != "UND" { seen[$NF] = 1 } +/^GLIBC_PRIVATE / { + seen[$2] = 1 +} END { status = 0; for (s in required) { - s = s "@@GLIBC_PRIVATE" if (s in seen) print s, "ok"; else { status = 1; @@ -33,7 +29,6 @@ END { any = ""; for (s in th_unique) { - s = s "@@GLIBC_PRIVATE" if (s in seen) { any = s; break; |