about summary refs log tree commit diff
path: root/nptl/nptl_free_tcb.c
diff options
context:
space:
mode:
authorWilco Dijkstra <wdijkstr@arm.com>2022-09-13 11:58:07 +0100
committerWilco Dijkstra <wdijkstr@arm.com>2022-09-13 11:58:07 +0100
commita30e960328fc60e066967d1224ecd5b6e173cda3 (patch)
tree20fe8ff72d39d2c4fe3d867a19e88621bbd095c5 /nptl/nptl_free_tcb.c
parentf278835f594740f5913001430641cf1da4878670 (diff)
downloadglibc-a30e960328fc60e066967d1224ecd5b6e173cda3.tar.gz
glibc-a30e960328fc60e066967d1224ecd5b6e173cda3.tar.xz
glibc-a30e960328fc60e066967d1224ecd5b6e173cda3.zip
Use relaxed atomics since there is no MO dependence
Replace the 3 uses of atomic_bit_set and atomic_bit_test_set with
atomic_fetch_or_relaxed.  Using relaxed MO is correct since the
atomics are used to ensure memory is released only once.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
Diffstat (limited to 'nptl/nptl_free_tcb.c')
-rw-r--r--nptl/nptl_free_tcb.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/nptl/nptl_free_tcb.c b/nptl/nptl_free_tcb.c
index 0d31143ac8..86a8904898 100644
--- a/nptl/nptl_free_tcb.c
+++ b/nptl/nptl_free_tcb.c
@@ -24,7 +24,8 @@ void
 __nptl_free_tcb (struct pthread *pd)
 {
   /* The thread is exiting now.  */
-  if (atomic_bit_test_set (&pd->cancelhandling, TERMINATED_BIT) == 0)
+  if ((atomic_fetch_or_relaxed (&pd->cancelhandling, TERMINATED_BITMASK)
+      & TERMINATED_BITMASK) == 0)
     {
       /* Free TPP data.  */
       if (pd->tpp != NULL)