about summary refs log tree commit diff
path: root/misc/tst-error1.c
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>2024-05-06 13:20:56 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2024-06-25 12:11:48 -0300
commitc90cfce849d010474e8cccf3e5bff49a2c8b141f (patch)
treec9b85b8be86d28f7e2ddc49d9c7e9806a131e0d1 /misc/tst-error1.c
parent17a293c5fab878a0b59e31047f49833f156bdeef (diff)
downloadglibc-c90cfce849d010474e8cccf3e5bff49a2c8b141f.tar.gz
glibc-c90cfce849d010474e8cccf3e5bff49a2c8b141f.tar.xz
glibc-c90cfce849d010474e8cccf3e5bff49a2c8b141f.zip
posix: Fix pidfd_spawn/pidfd_spawnp leak if execve fails (BZ 31695)
If the pidfd_spawn/pidfd_spawnp helper process succeeds, but evecve
fails for some reason (either with an invalid/non-existent, memory
allocation, etc.) the resulting pidfd is never closed, nor returned
to caller (so it can call close).

Since the process creation failed, it should be up to posix_spawn to
also, close the file descriptor in this case (similar to what it
does to reap the process).

This patch also changes the waitpid with waitid (P_PIDFD) for pidfd
case, to avoid a possible pid re-use.

Checked on x86_64-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'misc/tst-error1.c')
0 files changed, 0 insertions, 0 deletions