about summary refs log tree commit diff
path: root/math/s_cacos_template.c
diff options
context:
space:
mode:
authorSzabolcs Nagy <szabolcs.nagy@arm.com>2021-12-31 09:50:50 +0000
committerSzabolcs Nagy <szabolcs.nagy@arm.com>2022-01-10 14:27:17 +0000
commit347a5b592c91f0230d52a5117fd83e1f75028207 (patch)
treecef1eb7585b59b17118ad72f82856b39f94cfd14 /math/s_cacos_template.c
parente72ef23ee88187284b4b1ca9b2e314e618429d35 (diff)
downloadglibc-347a5b592c91f0230d52a5117fd83e1f75028207.tar.gz
glibc-347a5b592c91f0230d52a5117fd83e1f75028207.tar.xz
glibc-347a5b592c91f0230d52a5117fd83e1f75028207.zip
math: Fix float conversion regressions with gcc-12 [BZ #28713]
Converting double precision constants to float is now affected by the
runtime dynamic rounding mode instead of being evaluated at compile
time with default rounding mode (except static object initializers).

This can change the computed result and cause performance regression.
The known correctness issues (increased ulp errors) are already fixed,
this patch fixes remaining cases of unnecessary runtime conversions.

Add float M_* macros to math.h as new GNU extension API.  To avoid
conversions the new M_* macros are used and instead of casting double
literals to float, use float literals (only required if the conversion
is inexact).

The patch was tested on aarch64 where the following symbols had new
spurious conversion instructions that got fixed:

  __clog10f
  __gammaf_r_finite@GLIBC_2.17
  __j0f_finite@GLIBC_2.17
  __j1f_finite@GLIBC_2.17
  __jnf_finite@GLIBC_2.17
  __kernel_casinhf
  __lgamma_negf
  __log1pf
  __y0f_finite@GLIBC_2.17
  __y1f_finite@GLIBC_2.17
  cacosf
  cacoshf
  casinhf
  catanf
  catanhf
  clogf
  gammaf_positive

Fixes bug 28713.

Reviewed-by: Paul Zimmermann <Paul.Zimmermann@inria.fr>
Diffstat (limited to 'math/s_cacos_template.c')
-rw-r--r--math/s_cacos_template.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/math/s_cacos_template.c b/math/s_cacos_template.c
index 644330f0f8..eaf7c80ade 100644
--- a/math/s_cacos_template.c
+++ b/math/s_cacos_template.c
@@ -32,7 +32,7 @@ M_DECL_FUNC (__cacos) (CFLOAT x)
     {
       y = M_SUF (__casin) (x);
 
-      __real__ res = (FLOAT) M_MLIT (M_PI_2) - __real__ y;
+      __real__ res = M_MLIT (M_PI_2) - __real__ y;
       if (__real__ res == 0)
 	__real__ res = 0;
       __imag__ res = -__imag__ y;