about summary refs log tree commit diff
path: root/include/clone_internal.h
diff options
context:
space:
mode:
authorAdhemerval Zanella Netto <adhemerval.zanella@linaro.org>2023-01-12 10:58:50 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2023-02-01 08:42:11 -0300
commit2290cf73cce1292d9345a8183fd29ae3994a9481 (patch)
tree293c1361e50d8fc4c6b22c57d35f51521a5c3d83 /include/clone_internal.h
parent2fe58919a0bfd1064c59120520116237ba818ed3 (diff)
downloadglibc-2290cf73cce1292d9345a8183fd29ae3994a9481.tar.gz
glibc-2290cf73cce1292d9345a8183fd29ae3994a9481.tar.xz
glibc-2290cf73cce1292d9345a8183fd29ae3994a9481.zip
Linux: Do not align the stack for __clone3
All internal callers of __clone3 should provide an already aligned
stack.  Removing the stack alignment in __clone3 is a net gain: it
simplifies the internal function contract (mask/unmask signals) along
with the arch-specific code.

Checked on x86_64-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'include/clone_internal.h')
-rw-r--r--include/clone_internal.h3
1 files changed, 3 insertions, 0 deletions
diff --git a/include/clone_internal.h b/include/clone_internal.h
index 73b8114df4..f8198d8059 100644
--- a/include/clone_internal.h
+++ b/include/clone_internal.h
@@ -11,6 +11,9 @@
    Different than kernel, the implementation also returns EINVAL for an
    invalid NULL __CL_ARGS or __FUNC (similar to __clone).
 
+   All callers are responsible for correctly aligning the stack.  The stack is
+   not aligned prior to the syscall (this differs from the exported __clone).
+
    This function is only implemented if the ABI defines HAVE_CLONE3_WRAPPER.
 */
 extern int __clone3 (struct clone_args *__cl_args, size_t __size,