about summary refs log tree commit diff
path: root/gmon/gmon.c
diff options
context:
space:
mode:
authorSergey Bugaev <bugaevc@gmail.com>2023-04-19 19:02:03 +0300
committerSamuel Thibault <samuel.thibault@ens-lyon.org>2023-04-22 13:50:14 +0200
commit533deafbdf189f5fbb280c28562dd43ace2f4b0f (patch)
tree292d1cf07d52199a9dd247c6bb06f5566c218855 /gmon/gmon.c
parent28a441cc577e31e95742b9ec5f1737b86749b712 (diff)
downloadglibc-533deafbdf189f5fbb280c28562dd43ace2f4b0f.tar.gz
glibc-533deafbdf189f5fbb280c28562dd43ace2f4b0f.tar.xz
glibc-533deafbdf189f5fbb280c28562dd43ace2f4b0f.zip
Use O_CLOEXEC in more places (BZ #15722)
When opening a temporary file without O_CLOEXEC we risk leaking the
file descriptor if another thread calls (fork and then) exec while we
have the fd open. Fix this by consistently passing O_CLOEXEC everywhere
where we open a file for internal use (and not to return it to the user,
in which case the API defines whether or not the close-on-exec flag
shall be set on the returned fd).

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
Message-Id: <20230419160207.65988-4-bugaevc@gmail.com>
Diffstat (limited to 'gmon/gmon.c')
-rw-r--r--gmon/gmon.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/gmon/gmon.c b/gmon/gmon.c
index bc0e29438a..6439ed1caa 100644
--- a/gmon/gmon.c
+++ b/gmon/gmon.c
@@ -384,13 +384,14 @@ write_gmon (void)
 	size_t len = strlen (env);
 	char buf[len + 20];
 	__snprintf (buf, sizeof (buf), "%s.%u", env, __getpid ());
-	fd = __open_nocancel (buf, O_CREAT|O_TRUNC|O_WRONLY|O_NOFOLLOW, 0666);
+	fd = __open_nocancel (buf, O_CREAT | O_TRUNC | O_WRONLY | O_NOFOLLOW
+			      | O_CLOEXEC, 0666);
       }
 
     if (fd == -1)
       {
-	fd = __open_nocancel ("gmon.out", O_CREAT|O_TRUNC|O_WRONLY|O_NOFOLLOW,
-			      0666);
+	fd = __open_nocancel ("gmon.out", O_CREAT | O_TRUNC | O_WRONLY
+			      | O_NOFOLLOW | O_CLOEXEC, 0666);
 	if (fd < 0)
 	  {
 	    char buf[300];