about summary refs log tree commit diff
path: root/elf/dl-tunables.c
diff options
context:
space:
mode:
authorSiddhesh Poyarekar <siddhesh@sourceware.org>2017-02-08 11:18:23 +0530
committerSiddhesh Poyarekar <siddhesh@sourceware.org>2017-02-08 14:17:17 +0530
commit8cbc826c37c0221ada65a7a622fe079b4e89a4b0 (patch)
tree598314eb1d2c9bb8da92f7c7f4cc25caf2cc31b4 /elf/dl-tunables.c
parent3f67d1a7021ed3184830511636a0867faec730fe (diff)
downloadglibc-8cbc826c37c0221ada65a7a622fe079b4e89a4b0.tar.gz
glibc-8cbc826c37c0221ada65a7a622fe079b4e89a4b0.tar.xz
glibc-8cbc826c37c0221ada65a7a622fe079b4e89a4b0.zip
Fix getting tunable values on big-endian (BZ #21109)
The code to set value passed a tunable_val_t, which when cast to
int32_t on big-endian gives the wrong value.  Instead, use
tunable_val_t.numval instead, which can then be safely cast into
int32_t.
Diffstat (limited to 'elf/dl-tunables.c')
-rw-r--r--elf/dl-tunables.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/elf/dl-tunables.c b/elf/dl-tunables.c
index a8d53d6a31..e42aa67003 100644
--- a/elf/dl-tunables.c
+++ b/elf/dl-tunables.c
@@ -455,6 +455,8 @@ __tunable_set_val (tunable_id_t id, void *valp, tunable_callback_t callback)
   if (cur->strval == NULL)
     return;
 
+  /* Caller does not need the value, just call the callback with our tunable
+     value.  */
   if (valp == NULL)
     goto cb;