diff options
| author | Roy Eldar <royeldar0@gmail.com> | 2023-05-25 17:41:58 +0300 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2023-05-25 18:50:59 +0200 |
| commit | dae801527386f94e9d2fabf23c37863d1b599153 (patch) | |
| tree | 297cda761c1f88e3f15502d2ae651b82175be984 /elf/dl-printf.c | |
| parent | 44d4d3bdcff67c7fa0b0c046fef9919e9c66c1b2 (diff) | |
| download | glibc-dae801527386f94e9d2fabf23c37863d1b599153.tar.gz glibc-dae801527386f94e9d2fabf23c37863d1b599153.tar.xz glibc-dae801527386f94e9d2fabf23c37863d1b599153.zip | |
elf: fix handling of negative numbers in dl-printf
_dl_debug_vdprintf is a bare-bones printf implementation; currently
printing a signed integer (using "%d" format specifier) behaves
incorrectly when the number is negative, as it just prints the
corresponding unsigned integer, preceeded by a minus sign.
For example, _dl_printf("%d", -1) would print '-4294967295'.
Signed-off-by: Roy Eldar <royeldar0@gmail.com>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Diffstat (limited to 'elf/dl-printf.c')
| -rw-r--r-- | elf/dl-printf.c | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/elf/dl-printf.c b/elf/dl-printf.c index e8b9900370..6efb4c019a 100644 --- a/elf/dl-printf.c +++ b/elf/dl-printf.c @@ -1,5 +1,6 @@ /* printf implementation for the dynamic loader. Copyright (C) 1997-2023 Free Software Foundation, Inc. + Copyright The GNU Toolchain Authors. This file is part of the GNU C Library. The GNU C Library is free software; you can redistribute it and/or @@ -150,19 +151,25 @@ _dl_debug_vdprintf (int fd, int tag_p, const char *fmt, va_list arg) if (long_mod) { if ((long int) num < 0) - negative = true; + { + num = -num; + negative = true; + } } else { if ((int) num < 0) { - num = (unsigned int) num; + num = -(unsigned int) num; negative = true; } } #else if ((int) num < 0) - negative = true; + { + num = -num; + negative = true; + } #endif } |