diff options
| author | Tomas Dohnalek <tdohnale@redhat.com> | 2014-02-15 01:04:57 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2014-02-15 01:04:57 +0000 |
| commit | 591aeaf7a99bc9aa9179f013114d92496952dced (patch) | |
| tree | 9aed1ca2715950e4853ffff3df706dc8fb08dccd /Rules | |
| parent | 7f98f1806a9b13fc6425566693e6674fd44e33e4 (diff) | |
| download | glibc-591aeaf7a99bc9aa9179f013114d92496952dced.tar.gz glibc-591aeaf7a99bc9aa9179f013114d92496952dced.tar.xz glibc-591aeaf7a99bc9aa9179f013114d92496952dced.zip | |
Generate .test-result files for ordinary tests.
This patch, an updated version of <https://sourceware.org/ml/libc-alpha/2014-01/msg00193.html>, starts the process of generating explicit PASS or FAIL status for individual glibc tests. It's based on Tomas Dohnalek's patch <https://sourceware.org/ml/libc-alpha/2012-10/msg00278.html>, but is deliberately more minimal: it doesn't try to cover any tests outside of $(tests) / $(xtests) (that's for a later patch), nor does it put the result together in an overall summary file (again, a later patch): it just generates the .test-result files. Thus, this patch keeps the overall logic for when a testsuite run finishes completely unchanged: a test failing will terminate the run. I think we *should* move to a more conventional approach where plain "make check" does not terminate for an individual test failure, unless e.g. you say "make stop-on-test-failure=y check", but that sort of policy change is best done as a separate patch once the infrastructure is in place to generate summary files for completed test runs (which will entirely consist of PASS and XFAIL lines if the testsuite run reaches the point of generating them, until such a policy change is made). Tested x86_64. 2014-02-14 Tomas Dohnalek <tdohnale@redhat.com> Joseph Myers <joseph@codesourcery.com> * Makeconfig (test-name): New variable. (evaluate-test): Likewise. * Makerules (do-test-clean): Remove .test-result files. (common-mostlyclean): Likewise. * Rules ($(objpfx)%.out): Use $(evaluate-test) in both rules. * scripts/evaluate-test.sh: New file.
Diffstat (limited to 'Rules')
| -rw-r--r-- | Rules | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/Rules b/Rules index 49ca8ea7a2..3e305ddaa5 100644 --- a/Rules +++ b/Rules @@ -183,9 +183,11 @@ make-test-out = $(test-wrapper-env) \ GCONV_PATH=$(common-objpfx)iconvdata LC_ALL=C \ $($*-ENV) $(host-test-program-cmd) $($*-ARGS) $(objpfx)%.out: %.input $(objpfx)% - $(make-test-out) > $@ < $(word 1,$^) + $(make-test-out) > $@ < $(word 1,$^); \ + $(evaluate-test) $(objpfx)%.out: /dev/null $(objpfx)% # Make it 2nd arg for canned sequence. - $(make-test-out) > $@ + $(make-test-out) > $@; \ + $(evaluate-test) endif # tests |