diff options
| author | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2019-02-21 13:33:54 -0300 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2019-05-14 08:48:02 -0300 |
| commit | c50e1c263ec15e98da3235e663049156fd1afcfa (patch) | |
| tree | 47d22df898622b32fdc262f830978f29d6fa800e /ChangeLog | |
| parent | 959aff9fa22c45e0fa11cd88c9f8ea10bd9ba494 (diff) | |
| download | glibc-c50e1c263ec15e98da3235e663049156fd1afcfa.tar.gz glibc-c50e1c263ec15e98da3235e663049156fd1afcfa.tar.xz glibc-c50e1c263ec15e98da3235e663049156fd1afcfa.zip | |
x86: Remove arch-specific low level lock implementation
This patch removes the arch-specific x86 assembly implementation for low level locking and consolidate both 64 bits and 32 bits in a single implementation. Different than other architectures, x86 lll_trylock, lll_lock, and lll_unlock implements a single-thread optimization to avoid atomic operation, using cmpxchgl instead. This patch implements by using the new single-thread.h definitions in a generic way, although using the previous semantic. The lll_cond_trylock, lll_cond_lock, and lll_timedlock just use atomic operations plus calls to lll_lock_wait*. For __lll_lock_wait_private and __lll_lock_wait the generic implemtation there is no indication that assembly implementation is required performance-wise. Checked on x86_64-linux-gnu and i686-linux-gnu. * sysdeps/nptl/lowlevellock.h (__lll_trylock): New macro. (lll_trylock): Call __lll_trylock. * sysdeps/unix/sysv/linux/i386/libc-lowlevellock.S: Remove file. * sysdeps/unix/sysv/linux/i386/lll_timedlock_wait.c: Likewise. * sysdeps/unix/sysv/linux/i386/lowlevellock.S: Likewise. * sysdeps/unix/sysv/linux/i386/lowlevellock.h: Likewise. * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise. * sysdeps/unix/sysv/linux/x86_64/lll_timedlock_wait.c: Likewise. * sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: Likewise. * sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Likewise. * sysdeps/unix/sysv/linux/x86/lowlevellock.h: New file. * sysdeps/unix/sysv/linux/x86_64/cancellation.S: Include lowlevellock-futex.h.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 4cb846f476..98c0a80be2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,19 @@ 2019-05-14 Adhemerval Zanella <adhemerval.zanella@linaro.org> + * sysdeps/nptl/lowlevellock.h (__lll_trylock): New macro. + (lll_trylock): Call __lll_trylock. + * sysdeps/unix/sysv/linux/i386/libc-lowlevellock.S: Remove file. + * sysdeps/unix/sysv/linux/i386/lll_timedlock_wait.c: Likewise. + * sysdeps/unix/sysv/linux/i386/lowlevellock.S: Likewise. + * sysdeps/unix/sysv/linux/i386/lowlevellock.h: Likewise. + * sysdeps/unix/sysv/linux/x86_64/libc-lowlevellock.S: Likewise. + * sysdeps/unix/sysv/linux/x86_64/lll_timedlock_wait.c: Likewise. + * sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: Likewise. + * sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Likewise. + * sysdeps/unix/sysv/linux/x86/lowlevellock.h: New file. + * sysdeps/unix/sysv/linux/x86_64/cancellation.S: Include + lowlevellock-futex.h. + * nptl/nptl-init.c (__pthread_initialize_minimal_internal): Remove initialization for LLL_LOCK_INITIALIZER different than 0. * nptl/old_pthread_cond_broadcast.c (__pthread_cond_broadcast_2_0): |