diff options
author | Chris Metcalf <cmetcalf@mellanox.com> | 2016-11-10 20:08:24 -0500 |
---|---|---|
committer | Chris Metcalf <cmetcalf@mellanox.com> | 2016-11-10 20:08:24 -0500 |
commit | a329844ff8adaffc25343a6f9bb12a3a9e841018 (patch) | |
tree | 8079df2592ed6345ad42be727fe110bddc852c99 /ChangeLog | |
parent | b4e75104b432e86dc8e308e8f58391bee6b33d78 (diff) | |
download | glibc-a329844ff8adaffc25343a6f9bb12a3a9e841018.tar.gz glibc-a329844ff8adaffc25343a6f9bb12a3a9e841018.tar.xz glibc-a329844ff8adaffc25343a6f9bb12a3a9e841018.zip |
Make sure tilepro uses kernel atomics fo atomic_store
It's not legal for raw stores to be mixed with atomic operations on tilepro, since the atomics are managed by kernel fast syscalls. It's possible for a hardware store and a kernel fast atomic to race with each other in such a way that the hardware store is lost. Suppose you have an initial zero value, and you race with a store of 2 and a kernel cmpxchg from 0 to 1. The legal output is only 2: either the store hit first and the cmpxchg failed, or the cmpxchg hit first and succeeded, then was overwritten by the 2. But if the kernel cmpxchg starts first and loads the zero, then the store hits and sets the value to 2, the cmpxchg will still decide it was successful and write the 1, leaving the value illegally set to 1. Using atomic_exchange variants to implement atomic_store fixes this problem for tilepro.
Diffstat (limited to 'ChangeLog')
-rw-r--r-- | ChangeLog | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ChangeLog b/ChangeLog index 40ef733564..262069d694 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2016-11-10 Chris Metcalf <cmetcalf@mellanox.com> + + * sysdeps/tile/tilepro/atomic-machine.h (atomic_store_relaxed) + (atomic_store_release): Provide tilepro-specific implementations. + 2016-11-10 Joseph Myers <joseph@codesourcery.com> * math/math.h (__MATH_TG): New macro. |